-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add workflow e2e test #1318
add workflow e2e test #1318
Conversation
cmd/repl/repl.go
Outdated
if !isTerminal { | ||
fmt.Println("sqlflow>", stmt) | ||
} | ||
tableRendered := false | ||
table := tablewriter.NewWriter(os.Stdout) | ||
|
||
stream := sql.RunSQLProgram(stmt, db, modelDir, &pb.Session{}) | ||
stream := sql.RunSQLProgram(stmt, modelDir, &pb.Session{DbConnStr: ds}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry this is cause by previous commit: https://github.com/sql-machine-learning/sqlflow/pull/1281/files#diff-f1bebf56ba6d498c6b1d0a104ead3e62R117
Thanks for @typhoonzero 's review, I found some bug that blocks this e2e test, so I renamed this PR to WIP status and will create some PRs to fix these bugs while updating this e2e test. |
Cool! |
cmd/sqlflowserver/main_test.go
Outdated
@@ -478,6 +480,80 @@ func TestEnd2EndMaxComputeElasticDL(t *testing.T) { | |||
t.Run("CaseTrainElasticDL", CaseTrainElasticDL) | |||
} | |||
|
|||
func TestEnd2EndMySQLArgoMode(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing MySQL requires starting a MySQL server inside a Pod. Maybe we should use MaxCompute as data source instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using MySQL can check each PR that comes from forked PR, maybe it can cover more test case.
244d027
to
b69c256
Compare
…o workflow_e2e_test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
the part workflow of #1066
This PR adds an e2e test for the SQLFLow workflow.
The workflow step failed on REPL executing the SQL program #1317