fix repl always return 0 #1286
fix repl always return 0 #1286
Conversation
| @@ -81,15 +81,13 @@ func render(rsp interface{}, table *tablewriter.Table) bool { | |||
| table.Append(row) | |||
| isTable = true | |||
| case error: | |||
| if os.Getenv("SQLFLOW_log_dir") != "" { // To avoid printing duplicated error message to console | |||
| log.New(os.Stderr, "", 0).Printf("ERROR: %v\n", s) | |||
There was a problem hiding this comment.
We'd better keep this check somewhere to avoid printing error message twice when logging to stderr.
There was a problem hiding this comment.
Maybe we can use log.Fatalf to exit if some errors.
There was a problem hiding this comment.
log.Fatalf will terminate the program, that's no good for the interactive mode of REPL.
pkg/sql/model.go
Outdated
| @@ -86,7 +86,6 @@ func (m *model) saveDB(db *DB, table string, session *pb.Session) (e error) { | |||
| if e != nil { | |||
| return fmt.Errorf("cannot create sqlfs file %s: %v", table, e) | |||
| } | |||
| defer sqlf.Close() | |||
There was a problem hiding this comment.
How about defering with the new Close code in a lambda?
There was a problem hiding this comment.
I believe should check the error of hiveWriter.Close, I updated this PR follow https://www.joeshaw.org/dont-defer-close-on-writable-files/ that uses a safe way to close sqlfs.
There was a problem hiding this comment.
Is it safe if we call hiveWriter.Close twice?
There was a problem hiding this comment.
Please checkout @shendiaomo 's comments and fix them in next PR?
fixed #1277
fixed #1317
related #1318