Delay initialize db object #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yancey1989
force-pushed
the
later_init_db
branch
from
14088ba to
8c24fd3
Compare
typhoonzero
approved these changes
Dec 4, 2019
| @@ -105,15 +105,18 @@ func flagPassed(name ...string) bool { | |||
| return found | |||
| } | |||
|
|
|||
| func runStmt(stmt string, isTerminal bool, modelDir string, db *sql.DB, ds string) error { | |||
| func runStmt(stmt string, isTerminal bool, modelDir string, ds string) error { | |||
There was a problem hiding this comment.
Good idea, will polish it in the next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related PR #1318
This IR deferred initialization of
DBobject, so sqlflowserver don't need to initialize the DB object on Argo mode.