Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Capstone to newest next #4758

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Bump Capstone to newest next #4758

merged 5 commits into from
Dec 18, 2024

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Dec 6, 2024 •
edited
Loading

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

I would wait for the weekend release before merging. But this way we can run the tests.

Regression PR: capstone-engine/capstone#2575

Test plan

...

Closing issues

...

@Rot127 Rot127 changed the title Bumpt Capstone to newest next Bump Capstone to newest next Dec 6, 2024
@Rot127
Copy link
Member Author

Rot127 commented Dec 6, 2024

Ignore the mismatches in ids for now please. Fix them when a tag was added.

@Rot127 Rot127 force-pushed the dist-capstone-bump-csv6 branch 2 times, most recently from 96029b8 to 140ae64 Compare December 16, 2024 17:59
XVilka
XVilka requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on top of the latest dev to fix the CI

@Rot127 Rot127 force-pushed the dist-capstone-bump-csv6 branch from 3c1cbb3 to c9c3752 Compare December 17, 2024 12:27
XVilka
XVilka approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rot127 maybe merge this early? We can update the capstone commit one more time at a later stage if necessary.

@Rot127
Copy link
Member Author

Rot127 commented Dec 18, 2024 •
edited
Loading

Sure. Why not.
I rebase a last time.

@Rot127 Rot127 force-pushed the dist-capstone-bump-csv6 branch from c9c3752 to 795a0f2 Compare December 18, 2024 13:58
@XVilka XVilka merged commit 21fda95 into dev Dec 18, 2024
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

@XVilka XVilka XVilka approved these changes

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
ARM rz-test RzAnalysis RZIL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rot127 @XVilka @wargio