Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AArch64/ARM64] Update to Capstone v6/auto-sync #3785

Closed
wants to merge 44 commits into from
Closed

[AArch64/ARM64] Update to Capstone v6/auto-sync #3785

wants to merge 44 commits into from

Conversation

Rot127
Copy link
Member

@Rot127 Rot127 commented Aug 24, 2023 •
edited by XVilka
Loading

based on #3648

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Updates the AArch64/ARM64 module to Capstone's v6/auto-sync version.

Requires capstone-engine/capstone#2026 to be merged.

Test plan

  • Test build with different CS ver. < 6
  • All green

Closing issues

...

@Rot127 Rot127 added this to the 0.7.0 milestone Aug 24, 2023
@Rot127 Rot127 force-pushed the dist-cs-v6-aarch64 branch from af63f9e to 3ef7b49 Compare August 26, 2023 17:40
@github-actions github-actions bot removed the API label Aug 26, 2023
@Rot127 Rot127 force-pushed the dist-cs-v6-aarch64 branch 2 times, most recently from 187ee32 to e28a0d0 Compare August 28, 2023 16:57
@Rot127 Rot127 force-pushed the dist-cs-v6-aarch64 branch from c690cdf to fab0621 Compare October 11, 2023 21:37
@XVilka
Copy link
Member

XVilka commented Oct 18, 2023

Rebase on top of the latest dev

@XVilka
Copy link
Member

XVilka commented Nov 6, 2023

@Rot127 please rebase on top of the latest dev and to the latest commit in capstone-engine/capstone#2026

Rot127 added 15 commits November 6, 2023 08:25
@Rot127
[AArch64 CS v6 BEGIN] Change subproject config to use cs-auto-sync-aa…
7399e86 
…rch64 branch
@Rot127
Replace ARM64 with version sensitive macros.
4685687
@Rot127
Exclude alias if CS version >= 6
9cecbd0
@Rot127
Update access to writeback member
e94c736
@Rot127
Exclude instr alias from inclusion
a76f93e
@Rot127
Update memory operand printing to json.
d9b45ab
@Rot127
Enable real instr. detail only for AArch64
b5aa35d
@Rot127
Set correct arch name in meson.build for CS
2e80b0a
@Rot127
Fix U/SBFM instructions and their alias.
d71d413
@Rot127
Mark parameters with RZ_OUt/BORROW
d50da84
@Rot127
Optimize register extension to skip some, if the width already matches.
f9238f8
@Rot127
Adapt width and lsb of U/SBFM alias instructions (ImmR and ImmS are f…
9f244a4 
…rom U/SBFM).
@Rot127
Fix tests correct semantic buy bad syntax
d3d8deb
@Rot127
Pass alias MOV instructions to mov()
b107317
@Rot127
Handle CSET and CSETM alias
8162335
Rot127 added 26 commits November 6, 2023 08:36
@Rot127
Fix CNEG, CINV alias
f6ad586
@Rot127
Fix bfi and bfxil alias.
9d58e11
@Rot127
Fix sign extensions.
48ad5f1
@Rot127
Fix compare instructions.
7a5a394
@Rot127
Fix NEG, NGC, NGCS, NEGS, MVN
09a453d
@Rot127
Fix CINC
9d63a13
@Rot127
Fix multiply instructions.
adb9e7c
@Rot127
Fix ROR
dec513d
@Rot127
Run clang-format
8bb6c89
@Rot127
Handle CMP for ESIL
9bfc458
@Rot127
Handle new position of memory disponents of post index operands.
5b3fba4
@Rot127
Fix post-index operations.
f2724f2
@Rot127
Add missing writeback checks for Post and preindex
55d543c
@Rot127
Handle UBFM and SBFM alias
89e935a
@Rot127
Handl BFM alias
4a46cb6
@Rot127
Handle CMP, CSET and CINC alias
e825eb1
@Rot127
Update meson file of for cs-aarch64 branch
bc1edfa
@Rot127
Fix asm tests. Use reg alias now.
34b5697
@Rot127
Fix condition confusion and incorrect operand usage.
2198316
@Rot127
Fix plf test.
4e60720
@Rot127
Run clang-format
9aef59c
@Rot127
Use register alias in tests
fb94179
@Rot127
Add support for fp and lr reg alias assembly.
1a91862
@Rot127
Use reg alias in test
28c9417
@Rot127
Rename cond tranlate functions r2 -> rz
da03e5b
@Rot127
Fix condition check which assume 0 == invalid.
6d910f5
@Rot127 Rot127 force-pushed the dist-cs-v6-aarch64 branch from 82d0fec to 6d910f5 Compare November 6, 2023 13:42
@github-actions github-actions bot removed the PPC label Nov 6, 2023
@Rot127
Copy link
Member Author

Rot127 commented Nov 6, 2023 •
edited by XVilka
Loading

Superseded by #3963
(capstone must be in the branch name so the build with <v6 gets tested as well.)

@Rot127 Rot127 closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio Awaiting requested review from wargio wargio will be requested when the pull request is marked ready for review wargio is a code owner

@XVilka XVilka Awaiting requested review from XVilka XVilka will be requested when the pull request is marked ready for review XVilka is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy will be requested when the pull request is marked ready for review kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r will be requested when the pull request is marked ready for review thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc will be requested when the pull request is marked ready for review ret2libc is a code owner

Assignees
No one assigned
Labels
ARM capstone rz-test RzAnalysis RzAsm-Assembler RzCore
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Rot127 @XVilka