Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry: update metric + attribute names #931

Merged
merged 5 commits into from
Nov 15, 2024
+1,662 −1,639
Merged

OpenTelemetry: update metric + attribute names #931

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7e232d7
conn -> connection
sean-breen Nov 13, 2024
874c657
update metrics names -> 'conn' to 'connections'
sean-breen Nov 14, 2024
c55efa2
update metrics function calls in scrapers
sean-breen Nov 14, 2024
a9f8ea3
update grafana dashboards for mock env
sean-breen Nov 14, 2024
a800783
update expected metrics files for unit tests
sean-breen Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions internal/collector/nginxossreceiver/documentation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ metrics:
enabled: false
```

### nginx.http.conn
### nginx.http.connections

The total number of connections.

Expand All @@ -24,9 +24,9 @@ The total number of connections.

| Name | Description | Values |
| ---- | ----------- | ------ |
| nginx.conn.outcome | The outcome of the connection. | Str: ``ACCEPTED``, ``ACTIVE``, ``HANDLED``, ``READING``, ``WRITING``, ``WAITING`` |
| nginx.connections.outcome | The outcome of the connection. | Str: ``ACCEPTED``, ``ACTIVE``, ``HANDLED``, ``READING``, ``WRITING``, ``WAITING`` |

### nginx.http.conn.count
### nginx.http.connections.count

The current number of connections.

Expand All @@ -38,7 +38,7 @@ The current number of connections.

| Name | Description | Values |
| ---- | ----------- | ------ |
| nginx.conn.outcome | The outcome of the connection. | Str: ``ACCEPTED``, ``ACTIVE``, ``HANDLED``, ``READING``, ``WRITING``, ``WAITING`` |
| nginx.connections.outcome | The outcome of the connection. | Str: ``ACCEPTED``, ``ACTIVE``, ``HANDLED``, ``READING``, ``WRITING``, ``WAITING`` |

### nginx.http.requests

Expand Down
12 changes: 6 additions & 6 deletions internal/collector/nginxossreceiver/internal/metadata/generated_config.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions internal/collector/nginxossreceiver/internal/metadata/generated_config_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

148 changes: 74 additions & 74 deletions internal/collector/nginxossreceiver/internal/metadata/generated_metrics.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading