Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry: update metric + attribute names #931

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

sean-breen
Copy link

@sean-breen sean-breen commented Nov 14, 2024

Proposed changes

Renames some NGINX OSS + Nginx Plus metrics to be more verbose.

Occurrences of the abbreviation conn for connections have been changed to connections in most places. This includes in attribute names.

Old metric New metric
nginx.http.conn nginx.http.connections
Old attribute New attribute
nginx.conn.outcome nginx.connections.outcome

The only ones not affected are when the abbreviation matches a directive name in nginx configuration, such as limit_conn.

Also update the Grafana dashboards in our mock environment to use the new metric names, and leverage the instance.type resource attribute to filter based on Nginx instance type.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@sean-breen sean-breen requested a review from a team as a code owner November 14, 2024 15:02
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Improvements or additions to documentation labels Nov 14, 2024
@sean-breen sean-breen added go Pull requests that update Go code v3.x Issues and Pull Requests related to the major version v3 and removed documentation Improvements or additions to documentation chore Pull requests for routine tasks labels Nov 14, 2024
@sean-breen sean-breen merged commit b35fdab into v3 Nov 15, 2024
20 checks passed
@sean-breen sean-breen deleted the otel-update-metric-names branch November 15, 2024 12:15
sean-breen added a commit that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants