feat!: identity funding with asset lock special transactions #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eat/process-asset-locks
…eat/process-asset-locks
shumkov
changed the title
shumkov
changed the title
# Conflicts: # .pnp.cjs # packages/dashmate/configs/getConfigFileMigrationsFactory.js # packages/js-dapi-client/package.json # packages/js-dpp/lib/test/fixtures/getChainAssetLockProofFixture.js # packages/js-dpp/lib/test/fixtures/getInstantAssetLockProofFixture.js # packages/js-dpp/package.json # packages/rs-drive-abci/tests/strategy_tests/verify_state_transitions.rs # packages/rs-platform-version/src/version/drive_abci_versions.rs # packages/rs-platform-version/src/version/mocks/v2_test.rs # packages/rs-platform-version/src/version/mocks/v3_test.rs # packages/rs-platform-version/src/version/v1.rs # packages/wasm-dpp/test/unit/identity/stateTransition/assetLockProof/ChainAssetLockProof.spec.js # packages/wasm-dpp/test/unit/identity/stateTransition/assetLockProof/InstantAssetLockProof.spec.js # yarn.lock
shumkov
force-pushed
the
feat/process-asset-locks
branch
from
c11944d to
b82c18f
Compare
# Conflicts: # packages/dashmate/configs/getConfigFileMigrationsFactory.js
shumkov
force-pushed
the
feat/process-asset-locks
branch
from
6d2dac6 to
6905a64
Compare
# Conflicts: # packages/dashmate/configs/defaults/getBaseConfigFactory.js # packages/dashmate/configs/getConfigFileMigrationsFactory.js # packages/dashmate/src/config/configFile/migrateConfigFileFactory.js # packages/dashmate/test/unit/commands/config/configFile/migrateConfigFileFactory.spec.js
...es/rs-dpp/src/identity/state_transition/asset_lock_proof/instant/instant_asset_lock_proof.rs
Outdated
Show resolved
Hide resolved
| map.insert("outputIndex", self.output_index); | ||
| map.insert("transaction", transaction_buffer); | ||
| map.insert("instantLock", is_lock_buffer); | ||
|
|
||
| map.to_bytes() | ||
| .map_err(|e| ProtocolError::EncodingError(e.to_string())) | ||
| } | ||
|
|
||
| // TODO: Versioning |
There was a problem hiding this comment.
Really should be versioned now.
...e-abci/src/execution/validation/state_transition/common/asset_lock/one_time_signed/v0/mod.rs
Outdated
Show resolved
Hide resolved
| @@ -52,6 +53,8 @@ pub struct PlatformRef<'a, C> { | |||
| pub config: &'a PlatformConfig, | |||
| /// Core RPC Client | |||
| pub core_rpc: &'a C, | |||
| /// Block info | |||
| pub block_info: &'a BlockInfo, | |||
There was a problem hiding this comment.
No this is wrong, you don't add state information to the Platform Ref
| @@ -27,7 +27,7 @@ bs58 = "0.4.0" | |||
| hex = "0.4.3" | |||
| indexmap = { version = "1.9.3", features = ["serde"] } | |||
| sha2 = "0.10.6" | |||
| dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore-rpc", tag = "v0.15.1" } | |||
| dashcore-rpc = { git = "https://github.com/dashpay/rust-dashcore-rpc", branch = "master" } | |||
There was a problem hiding this comment.
We shouldn't be targeting master, instead should be a tag.
There was a problem hiding this comment.
Ok, I will release new version
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Currently, we are using normal transactions with OP_RETURN output to fund identities since it was a temporary solution to get the identity funding feature done earlier. Asset Lock validation logic was ported only partially from JS DPP and Drive.
What was done?
Transaction#getOutPointBuffer(JS)How Has This Been Tested?
Breaking Changes
Checklist:
For repository code-owners and collaborators only