Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dpp): version InstantAssetLockProof.validate_structure #1549

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Nov 2, 2023

Issue being fixed or feature implemented

Validate structure contains consensus logic and should be versioned. A todo to do so was introduced in #1510 and this PR is follow-up with the todo implemented

What was done?

  • Version InstantAssetLockProof.validate_structure method

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov modified the milestones: v0.25.x, v1.0.0 Nov 2, 2023
@QuantumExplorer QuantumExplorer merged commit 0b86cd2 into v1.0-dev Nov 2, 2023
26 of 28 checks passed
@QuantumExplorer QuantumExplorer deleted the chore/asset-lock-follow-up-fixes branch November 2, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants