feat!: identity funding with asset lock special transactions

packages/bench-suite/package.json

@@ -8,7 +8,7 @@
     "lint": "eslint ."
   },
   "dependencies": {
-    "@dashevo/dashcore-lib": "~0.20.9",
+    "@dashevo/dashcore-lib": "~0.20.10",
     "@dashevo/dpns-contract": "workspace:*",
     "@dashevo/dpp": "workspace:*",
     "@dashevo/wallet-lib": "workspace:*",

packages/dapi/package.json

@@ -35,7 +35,7 @@
   "dependencies": {
     "@dashevo/bls": "~1.2.9",
     "@dashevo/dapi-grpc": "workspace:*",
-    "@dashevo/dashcore-lib": "~0.20.9",
+    "@dashevo/dashcore-lib": "~0.20.10",
     "@dashevo/dashd-rpc": "^18.2.0",
     "@dashevo/dpp": "workspace:*",
     "@dashevo/grpc-common": "workspace:*",

packages/dash-spv/package.json

@@ -14,7 +14,7 @@
   "dependencies": {
     "@dashevo/dark-gravity-wave": "^1.1.1",
     "@dashevo/dash-util": "^2.0.3",
-    "@dashevo/dashcore-lib": "~0.20.9",
+    "@dashevo/dashcore-lib": "~0.20.10",
     "levelup": "^4.4.0",
     "memdown": "^5.1.0",
     "wasm-x11-hash": "~0.0.2"

packages/dashmate/package.json

@@ -49,7 +49,7 @@
   "homepage": "https://github.com/dashevo/dashmate#readme",
   "dependencies": {
     "@dashevo/bls": "~1.2.9",
-    "@dashevo/dashcore-lib": "~0.20.9",
+    "@dashevo/dashcore-lib": "~0.20.10",
     "@dashevo/dashd-rpc": "^18.2.0",
     "@dashevo/dashpay-contract": "workspace:*",
     "@dashevo/docker-compose": "^0.24.4",

packages/js-dapi-client/package.json

@@ -28,7 +28,7 @@
   "dependencies": {
     "@dashevo/dapi-grpc": "workspace:*",
     "@dashevo/dash-spv": "workspace:*",
-    "@dashevo/dashcore-lib": "~0.20.9",
+    "@dashevo/dashcore-lib": "~0.20.10",
     "@dashevo/dpp": "workspace:*",
     "@dashevo/grpc-common": "workspace:*",
     "@dashevo/wasm-dpp": "workspace:*",

packages/js-dash-sdk/package.json

@@ -41,7 +41,7 @@
     "@dashevo/bls": "~1.2.9",
     "@dashevo/dapi-client": "workspace:*",
     "@dashevo/dapi-grpc": "workspace:*",
-    "@dashevo/dashcore-lib": "~0.20.9",
+    "@dashevo/dashcore-lib": "~0.20.10",
     "@dashevo/dashpay-contract": "workspace:*",
     "@dashevo/dpns-contract": "workspace:*",
     "@dashevo/dpp": "workspace:*",

packages/js-dash-sdk/src/SDK/Client/Platform/createAssetLockTransaction.ts

@@ -1,4 +1,6 @@
-import { PrivateKey, Transaction } from '@dashevo/dashcore-lib';
+import {
+  PrivateKey, Transaction, Script, Address, Opcode,
+} from '@dashevo/dashcore-lib';
 import { utils } from '@dashevo/wallet-lib';
 import { Platform } from './Platform';
 
@@ -44,11 +46,35 @@ export async function createAssetLockTransaction(
 
   const selection = utils.coinSelection(utxos, [output]);
 
+  const realOutput = {
+    satoshis: output.satoshis,
+    script: Script
+      .buildPublicKeyHashOut(Address.fromString(identityAddress, this.client.network)).toString(),
+  };
+
+  const payload = Transaction.Payload.AssetLockPayload.fromJSON({
+    version: 1,
+    creditOutputs: [{
+      satoshis: realOutput.satoshis,
+      script: realOutput.script,
+    }],
+  });
+
   lockTransaction
+  // @ts-ignore
+    .setType(Transaction.TYPES.TRANSACTION_ASSET_LOCK)
     .from(selection.utxos)
-    // eslint-disable-next-line
-    .addBurnOutput(output.satoshis, assetLockOneTimePublicKey._getID())
-    .change(changeAddress);
+  // eslint-disable-next-line
+      .addOutput(
+      new Transaction.Output({
+        satoshis: realOutput.satoshis,
+        // @ts-ignore
+        script: new Script().add(Opcode.OP_RETURN).add(Buffer.alloc(0)),
+      }),
+    )
+    .change(changeAddress)
+  // @ts-ignore
+    .setExtraPayload(payload);
 
   const utxoAddresses = selection.utxos.map((utxo: any) => utxo.address.toString());
 

packages/js-dash-sdk/src/SDK/Client/Platform/methods/identities/register.ts

@@ -35,7 +35,7 @@ export default async function register(
   const { identity, identityCreateTransition, identityIndex } = await this.identities.utils
     .createIdentityCreateTransition(assetLockProof, assetLockPrivateKey);
 
-  this.logger.silly(`[Identity#register] Created IdentityCreateTransition with asset lock tx "${assetLockTransaction.hash}"`);
+  this.logger.silly(`[Identity#register] Created IdentityCreateTransition with identity id "${identity.getId()}" using asset lock tx "${assetLockTransaction.hash}" `);
 
   // Skipping validation because it's already done in createIdentityCreateTransition
   await broadcastStateTransition(this, identityCreateTransition, {

packages/js-dash-sdk/src/SDK/Client/Platform/methods/names/register.ts

@@ -48,8 +48,6 @@ export async function register(this: Platform,
   const [label] = nameLabels;
   const normalizedLabel = convertToHomographSafeChars(label);
 
-  console.log('Label', label, 'normalized', normalizedLabel);
-
   const preorderSalt = crypto.randomBytes(32);
 
   const isSecondLevelDomain = normalizedParentDomainName.length > 0;

packages/js-dpp/package.json

@@ -84,7 +84,7 @@
   "dependencies": {
     "@apidevtools/json-schema-ref-parser": "^8.0.0",
     "@dashevo/bls": "~1.2.9",
-    "@dashevo/dashcore-lib": "~0.20.9",
+    "@dashevo/dashcore-lib": "~0.20.10",
     "@dashevo/dashpay-contract": "workspace:*",
     "@dashevo/dpns-contract": "workspace:*",
     "@dashevo/feature-flags-contract": "workspace:*",

packages/platform-test-suite/package.json

@@ -24,7 +24,7 @@
   "homepage": "https://github.com/dashevo/platform-test-suite#readme",
   "dependencies": {
     "@dashevo/dapi-client": "workspace:*",
-    "@dashevo/dashcore-lib": "~0.20.9",
+    "@dashevo/dashcore-lib": "~0.20.10",
     "@dashevo/dpns-contract": "workspace:*",
     "@dashevo/dpp": "workspace:*",
     "@dashevo/feature-flags-contract": "workspace:*",

packages/rs-dpp/src/errors/protocol_error.rs

@@ -15,8 +15,8 @@ use crate::state_transition::errors::{
     StateTransitionError, StateTransitionIsNotSignedError, WrongPublicKeyPurposeError,
 };
 use crate::{
-    CompatibleProtocolVersionIsNotDefinedError, DashPlatformProtocolInitError, NonConsensusError,
-    SerdeParsingError,
+    CompatibleProtocolVersionIsNotDefinedError, DashPlatformProtocolInitError,
+    InvalidVectorSizeError, NonConsensusError, SerdeParsingError,
 };
 
 use dashcore::consensus::encode::Error as DashCoreError;
@@ -207,6 +207,9 @@ pub enum ProtocolError {
 
     #[error("critical corrupted credits code execution: {0}")]
     CriticalCorruptedCreditsCodeExecution(String),
+
+    #[error(transparent)]
+    InvalidVectorSizeError(InvalidVectorSizeError),
 }
 
 impl From<&str> for ProtocolError {
@@ -244,3 +247,9 @@ impl From<DashPlatformProtocolInitError> for ProtocolError {
         ProtocolError::Generic(e.to_string())
     }
 }
+
+impl From<InvalidVectorSizeError> for ProtocolError {
+    fn from(err: InvalidVectorSizeError) -> Self {
+        Self::InvalidVectorSizeError(err)
+    }
+}

packages/rs-dpp/src/identity/identity_factory.rs

@@ -1,5 +1,6 @@
 use crate::identity::state_transition::asset_lock_proof::chain::ChainAssetLockProof;
 use crate::identity::state_transition::asset_lock_proof::{AssetLockProof, InstantAssetLockProof};
+use crate::identity::state_transition::AssetLockProved;
 #[cfg(all(feature = "state-transitions", feature = "client"))]
 use crate::identity::{IdentityV0, TimestampMillis};
 

packages/rs-dpp/src/identity/state_transition/asset_lock_proof/chain/chain_asset_lock_proof.rs

@@ -1,20 +1,25 @@
-use platform_value::{Bytes36, Value};
-use serde::{Deserialize, Serialize};
+use ::serde::{Deserialize, Serialize};
+use platform_value::Value;
 use std::convert::TryFrom;
 
 use crate::{
-    errors::NonConsensusError, identifier::Identifier, util::hash::hash_to_vec,
-    util::vec::vec_to_array, ProtocolError,
+    identifier::Identifier, util::hash::hash_to_vec, util::vec::vec_to_array, ProtocolError,
 };
 pub use bincode::{Decode, Encode};
+use dashcore::consensus::Encodable;
+use dashcore::OutPoint;
 
-#[derive(Clone, PartialEq, Eq, Debug, Serialize, Deserialize, Encode, Decode)]
+/// Instant Asset Lock Proof is a part of Identity Create and Identity Topup
+/// transitions. It is a proof that specific output of dash is locked in credits
+/// pull and the transitions can mint credits and populate identity's balance.
+/// To prove that the output is locked, a height where transaction was chain locked is provided.
+#[derive(Clone, PartialEq, Eq, Debug, Serialize, Deserialize)]
 #[serde(rename_all = "camelCase")]
 pub struct ChainAssetLockProof {
-    #[serde(rename = "type")]
-    asset_lock_type: u8,
+    /// Core height on which the asset lock transaction was chain locked or higher
     pub core_chain_locked_height: u32,
-    pub out_point: Bytes36,
+    /// A reference to Asset Lock Special Transaction ID and output index in the payload
+    pub out_point: OutPoint,
 }
 
 impl TryFrom<Value> for ChainAssetLockProof {
@@ -34,21 +39,23 @@ impl ChainAssetLockProof {
 
     pub fn new(core_chain_locked_height: u32, out_point: [u8; 36]) -> Self {
         Self {
-            // TODO: change to const
-            asset_lock_type: 1,
             core_chain_locked_height,
-            out_point: Bytes36::new(out_point),
+            out_point: OutPoint::from(out_point),
         }
     }
 
-    /// Get proof type
-    pub fn asset_lock_type() -> u8 {
-        1
-    }
-
     /// Create identifier
-    pub fn create_identifier(&self) -> Result<Identifier, NonConsensusError> {
-        let array = vec_to_array(hash_to_vec(self.out_point.as_slice()).as_ref())?;
-        Ok(Identifier::new(array))
+    pub fn create_identifier(&self) -> Result<Identifier, ProtocolError> {
+        let mut outpoint_bytes = Vec::new();
+
+        self.out_point
+            .consensus_encode(&mut outpoint_bytes)
+            .map_err(|e| ProtocolError::EncodingError(e.to_string()))?;
+
+        let hash = hash_to_vec(&outpoint_bytes);
+
+        let hash_array = vec_to_array(&hash)?;
+
+        Ok(Identifier::new(hash_array))
     }
 }

packages/rs-dpp/src/identity/state_transition/asset_lock_proof/chain/mod.rs

@@ -1,3 +1,2 @@
 pub use chain_asset_lock_proof::*;
-
 mod chain_asset_lock_proof;