Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update reference design page #452

Merged
merged 12 commits into from
Oct 27, 2023

Conversation

NilaySener
Copy link
Contributor

@NilaySener NilaySener commented Sep 11, 2023

Description

Updated information of sensors and systems has been added to the Reference HW section.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@NilaySener NilaySener force-pushed the add-reference-hw-design branch from 3c6e5d0 to 94c04d1 Compare September 11, 2023 13:35
@NilaySener NilaySener added the type:documentation Creating or refining documentation. label Sep 11, 2023
@ismetatabay ismetatabay marked this pull request as ready for review September 11, 2023 13:53
@NilaySener NilaySener requested a review from xmfcx September 11, 2023 13:55
@NilaySener NilaySener self-assigned this Sep 11, 2023
@NilaySener NilaySener added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Sep 11, 2023
@NilaySener NilaySener marked this pull request as draft September 12, 2023 12:08
@NilaySener NilaySener force-pushed the add-reference-hw-design branch from 88922f4 to cad4127 Compare September 12, 2023 12:08
@NilaySener NilaySener marked this pull request as ready for review September 12, 2023 16:27
Copy link

@armaganarsln armaganarsln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from changes in the how to create maps the document looks good.

docs/reference-hw/cameras.md Outdated Show resolved Hide resolved
docs/reference-hw/cameras.md Outdated Show resolved Hide resolved
docs/reference-hw/ad_sensor_kit_suppliers.md Outdated Show resolved Hide resolved
docs/reference-hw/ad_sensor_kit_suppliers.md Outdated Show resolved Hide resolved
docs/reference-hw/ad_sensor_kit_suppliers.md Outdated Show resolved Hide resolved
@mitsudome-r
Copy link
Member

Thanks for the PR!
I did made a review on TIER IV related sections. They seem general good in terms of context. I made some small comments about the company name.

Signed-off-by: Nilay Şener <[email protected]>
Signed-off-by: NilaySener <[email protected]>

style(pre-commit): autofix

Signed-off-by: NilaySener <[email protected]>

fix broken link

Signed-off-by: NilaySener <[email protected]>

style(pre-commit): autofix

add sensor kit suppliers

Signed-off-by: NilaySener <[email protected]>

style(pre-commit): autofix

add photos of the products

Signed-off-by: NilaySener <[email protected]>

autofix correction

Signed-off-by: NilaySener <[email protected]>

style(pre-commit): autofix

apply suggestions

Co-authored-by: Ryohsuke Mitsudome <[email protected]>
@NilaySener NilaySener force-pushed the add-reference-hw-design branch from ef5ffb3 to 6ff1da1 Compare September 21, 2023 12:50
Signed-off-by: NilaySener <[email protected]>
@NilaySener NilaySener force-pushed the add-reference-hw-design branch from 152cbbf to 9f20e09 Compare September 21, 2023 12:51
@NilaySener NilaySener marked this pull request as draft September 21, 2023 13:34
@NilaySener NilaySener marked this pull request as ready for review September 21, 2023 15:09
Signed-off-by: NilaySener <[email protected]>
@NilaySener NilaySener force-pushed the add-reference-hw-design branch from 99ec623 to 5252734 Compare September 21, 2023 15:11
@evshary
Copy link
Member

evshary commented Sep 27, 2023

@NilaySener I've updated the description of ADLINK IPC in this branch.
NilaySener#1

@xmfcx
Copy link
Contributor

xmfcx commented Oct 25, 2023

@armaganarsln could you approve if the changes you've requested are applied?

Copy link

@armaganarsln armaganarsln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work. We could release it as the first version and update it next year with new information.

@xmfcx xmfcx merged commit ffa8491 into autowarefoundation:main Oct 27, 2023
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants