-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PlayerOne cameras: update to SDK version V3.7.1 #1278
Conversation
agalasso
commented
Jan 2, 2025
- Merge prior work on PlayerOne cameras with Ethan's
- format source files with clang-format
- tested with vendor's camera on Mac and Windows
@EthanChappel FYI this PR is the result of merging my earlier work on Player One cameras with your recent PR. Most of the changes are just renaming some things (like poa => playerone), adding the script to unpack the SDK libs (unpack_playerone_sdk), formatting with clang-format, and fixes for MacOS (install_name_tool stuff in CMakeLists.txt). |
915e8b1
to
772c130
Compare
I think something here and in my fork #1280 has broken the program on Linux. Freezes until force closed when trying to open the camera switcher while Player One Camera is selected and one is attached to the PC. Does not freeze with no camera attached. Master branch with the initial work still acts as expected. Built and tested each branch on x64 Linux multiple times to verify. All branches seem to skip installing the Player One shared object when running |
I found one issue: cmake installs libPlayerOneCamera.so which is a broken symlink to libPlayerOneCamera.so.3.7.1, and phd2.bin actually wants to load libPlayerOneCamera.so.3 which does not exist. I will fix this in this branch shortly ... |
@bwdev01 please let me know if you would like more time to review this. If so I'll hold off on merging, otherwise I'll just merge it some time today. |
phd2.sh was renamed to phd2.sh.in and it seems to have broken
|
* Merge prior work on PlayerOne cameras with Ethan's * format source files with clang-format * tested on Mac and Windows
50d3dda
to
3686443
Compare
@EthanChappel this branch was out of date with master. I just rebased the branch to fix it. I'm going to merge this to master now so we can un-block the dependent prs. |
Still having freezing/crashing on Linux (tested on arm64 and x64) when clicking the camera switcher button starting with 8a85159. Trying some things in |