Fix crash with Player One cameras on Linux #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@EthanChappel thanks for tracking that down. Interesting that I never saw the issue on my Linux, Mac or Windows systems so hopefully this really is the root cause. Even if it is not the root cause, the change is harmless and worth taking in case it really is the root cause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to select or connect to Player One cameras on Linux has crashed the program since #1278. Renaming the
POACameraclass to something else likePlayerOneCamerafixes the issue, since the Player One SDK may already uses the name.Tested on x64, Arm64 Debian 12 and Windows 11.