Windows build: improvement to DLL copying #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy the Windows DLL with a single call to `cmake -E` rather than one call per DLL. This slightly speeds up the build for a better experience in iterative developement on Windows. Also moves the DLL copying to POST_BUILD rather then PRE_BUILD as there's no point in copying the DLLs if there's going to be a compile error during iterative development.
agalasso
force-pushed
the
andy/Windows-cmake-DLL-copying-improvement
branch
from
7340b90 to
fe549e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the Windows DLLs with a single call to
cmake -Erather than one call per DLL. This slightly speeds up the build for a better experience in iterative development on Windows.Also moves the DLL copying to POST_BUILD rather then PRE_BUILD as there's no point in copying the DLLs if there's going to be a compile error during iterative development.