Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drone Based Lazer Rework #103

Merged
merged 4 commits into from
Apr 3, 2021
Merged

Drone Based Lazer Rework #103

merged 4 commits into from
Apr 3, 2021

Conversation

iskandarzulkarnaien
Copy link
Member

@iskandarzulkarnaien iskandarzulkarnaien commented Apr 3, 2021 •
edited
Loading

  • Lazer firing now spawns a drone, which does the charge up and fire in
    place of players
  • Players are no longer immobilized when firing drones
  • Deploying a drone consumes one available drone
  • Players regenerate drones at a fixed rate, up to a maximum cap
  • Players may place down drones as long as they have drones
  • AI uses the above changes
  • Player rotates instantaneously

Fixes: #13, #100

@iskandarzulkarnaien
Import LazerDrone assets
5d7740a
@iskandarzulkarnaien
Rework lazer firing to use deployable drones
42fb24f 
* Lazer firing now spawns a drone, which does the charge up and fire in
  place of players
* Players are no longer immobilized when firing drones
* Deploying a drone consumes one available drone
* Players regenerate drones at a fixed rate, up to a maximum cap
* Players may place down drones as long as they have drones
* AI uses these changes as well
@iskandarzulkarnaien iskandarzulkarnaien self-assigned this Apr 3, 2021
@J-Dan23
Copy link
Contributor

J-Dan23 commented Apr 3, 2021

Works fine. AI definitely needs tweaking to not have it run in the direction of drone fire. UI should probably reflect number of useable drones available to the player (UI-related change)

Personal comment: I find the current turret's design not very intuitive (it fires in direction of pointy bit not glowy bit) but that's just an asset swap issue that can be handled later when we find a nice asset to use.

@iskandarzulkarnaien iskandarzulkarnaien mentioned this pull request Apr 3, 2021
Open
@iskandarzulkarnaien iskandarzulkarnaien mentioned this pull request Apr 3, 2021
Open
J-Dan23
J-Dan23 approved these changes Apr 3, 2021
View reviewed changes
Copy link
Contributor

@J-Dan23 J-Dan23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine. I do enjoy the drone gameplay

@iskandarzulkarnaien iskandarzulkarnaien merged commit 30c41aa into dev-release Apr 3, 2021
@iskandarzulkarnaien iskandarzulkarnaien deleted the lazer-rework branch April 3, 2021 19:40
This was referenced Apr 3, 2021
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-Dan23 J-Dan23 J-Dan23 approved these changes

@dargohzy dargohzy Awaiting requested review from dargohzy

Assignees

@iskandarzulkarnaien iskandarzulkarnaien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iskandarzulkarnaien @J-Dan23