Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZigBeeUtcTime class and client/server #1371

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Use ZclCommandListener to avoid duplicate responses

4f2cb3d
Select commit
Loading
Failed to load commit list.
Open

Add ZigBeeUtcTime class and client/server #1371

Use ZclCommandListener to avoid duplicate responses
4f2cb3d
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded May 18, 2024 in 5s

21 new alerts

New alerts in code changed by this pull request

  • 5 warnings
  • 16 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 163 in com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/app/time/ZclTimeClient.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
ZclTimeCluster.getTime
Loading
should be avoided because it has been deprecated.

Check notice on line 278 in com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/app/time/ZclTimeClient.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
ZclTimeCluster.getTime
Loading
should be avoided because it has been deprecated.

Check notice on line 313 in com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/app/time/ZclTimeClient.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
ZclTimeCluster.getTime
Loading
should be avoided because it has been deprecated.

Check notice on line 322 in com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/app/time/ZclTimeClient.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
ZclTimeCluster.setTime
Loading
should be avoided because it has been deprecated.

Check notice on line 332 in com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/app/time/ZclTimeClient.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
ZclTimeCluster.setTimeStatus
Loading
should be avoided because it has been deprecated.

Check notice on line 338 in com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/app/time/ZclTimeClient.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
ZclTimeCluster.setDstStart
Loading
should be avoided because it has been deprecated.

Check notice on line 339 in com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/app/time/ZclTimeClient.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
ZclTimeCluster.setDstEnd
Loading
should be avoided because it has been deprecated.

Check notice on line 340 in com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/app/time/ZclTimeClient.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
ZclTimeCluster.setDstShift
Loading
should be avoided because it has been deprecated.

Check notice on line 343 in com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/app/time/ZclTimeClient.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
ZclTimeCluster.getLastSetTime
Loading
should be avoided because it has been deprecated.

Check notice on line 348 in com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/app/time/ZclTimeClient.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
ZclTimeCluster.getTime
Loading
should be avoided because it has been deprecated.

Check notice on line 364 in com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/app/time/ZclTimeClient.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
ZclTimeCluster.getTimeStatus
Loading
should be avoided because it has been deprecated.

Check notice on line 51 in com.zsmartsystems.zigbee/src/test/java/com/zsmartsystems/zigbee/app/time/ZclTimeServerTest.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note test

Invoking
ReadAttributesCommand.ReadAttributesCommand
Loading
should be avoided because it has been deprecated.

Check notice on line 56 in com.zsmartsystems.zigbee/src/test/java/com/zsmartsystems/zigbee/app/time/ZclTimeServerTest.java

See this annotation in the file changed.

Code scanning / CodeQL

Deprecated method or constructor invocation Note test

Invoking
ReadAttributesCommand.setIdentifiers
Loading
should be avoided because it has been deprecated.

Check notice on line 106 in com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/app/time/ZclTimeServer.java

See this annotation in the file changed.

Code scanning / CodeQL

Spurious Javadoc @param tags Note

@param tag "master" does not match any actual parameter of method "setSuperceding()".

Check notice on line 146 in com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/app/time/ZigBeeTimeExtension.java

See this annotation in the file changed.

Code scanning / CodeQL

Spurious Javadoc @param tags Note

@param tag "master" does not match any actual parameter of method "setSuperceding()".

Check warning on line 408 in com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/app/time/ZigBeeTimeExtension.java

See this annotation in the file changed.

Code scanning / CodeQL

Unused format argument Warning

This format call refers to 0 argument(s) but supplies 1 argument(s).

Check warning on line 399 in com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/app/time/ZclTimeClient.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
lastSet
Loading
may be null at this access because of
this
Loading
assignment.

Check warning on line 400 in com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/app/time/ZclTimeClient.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
lastTime
Loading
may be null at this access because of
this
Loading
assignment.

Check warning on line 239 in com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/app/time/ZigBeeTimeExtension.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
clientTime
Loading
may be null at this access because of
this
Loading
assignment.

Check warning on line 412 in com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/app/time/ZigBeeTimeExtension.java

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
client
Loading
may be null at this access as suggested by
this
Loading
null guard.

Check notice on line 408 in com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/app/time/ZigBeeTimeExtension.java

See this annotation in the file changed.

Code scanning / CodeQL

Use of default toString() Note

Default toString(): ZclTimeClient inherits toString() from Object, and so is not suitable for printing.