-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ZigBeeUtcTime class and client/server #1371
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Hey chris, apologies, I still didn't have time to test. |
@dschall I've updated this to use the |
Signed-off-by: Chris Jackson <[email protected]>
Signed-off-by: Chris Jackson <[email protected]>
Signed-off-by: Chris Jackson <[email protected]>
Signed-off-by: Chris Jackson <[email protected]>
9b3a60e
to
4f2cb3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This is something I wrote a while back but didn't create a PR so I need to try and remember how it all works :)
This creates a
ZigBeeUtcTime
class for managing time on a remote device. It then supports aZigBeeTimeExtension
which in turn can provide a localZclTimeClient
orZclTimeServer
to manage the time on the remote device.The
ZclTimeServer
is relatively simple in that it just responds to requests from the device.The
ZclTimeClient
is in itself also simple in that it provides methods to set the time on the remote.The
ZigBeeTimeExtension
tries to automate the time management by working out drift rates, and setting the clock proactively if the time has drifted outside spec and the device didn't update the time through a request to theZclTimeServer
.There is also a
ZigBeeConsoleTimeCommand
console command to get or set the time, and display the various information.This is potentially a breaking change if people are using time at the moment since this changes some interfaces from
Calendar
toZigBeeUtcTime
.I welcome comments on this and will wait a week or two before merging.
Signed-off-by: Chris Jackson [email protected]