Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

image: T4516: enable vyos-grub-update service #352

Merged
merged 2 commits into from
Nov 16, 2023
Merged

image: T4516: enable vyos-grub-update service #352

merged 2 commits into from
Nov 16, 2023

Conversation

jestabro
Copy link
Contributor

Change Summary

Needed for PR:
vyos/vyos-1x#1768

Both in draft pending fixes/additions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro self-assigned this May 23, 2023
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, sever-sever and c-po and removed request for a team May 23, 2023 02:01
@jestabro jestabro mentioned this pull request May 23, 2023
Merged
12 tasks
@jestabro jestabro marked this pull request as ready for review May 23, 2023 19:02
@vyosbot vyosbot requested a review from a team May 23, 2023 19:02
@jestabro jestabro marked this pull request as draft May 24, 2023 14:00
@c-po c-po added the current VyOS rolling release label Sep 15, 2023
@jestabro jestabro force-pushed the image-tools branch 3 times, most recently from 8bbca4a to fc73fbb Compare October 22, 2023 20:01
@jestabro jestabro force-pushed the image-tools branch 2 times, most recently from 0a9369b to b3dc542 Compare October 31, 2023 19:37
@jestabro jestabro force-pushed the image-tools branch 2 times, most recently from 32065a7 to a71662c Compare November 8, 2023 13:46
dmbaturin
dmbaturin approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything holding us back from taking this PR out of the draft status and merging it?

@jestabro
Copy link
Contributor Author

jestabro commented Nov 8, 2023

Is there anything holding us back from taking this PR out of the draft status and merging it?

This, and the related PR's are waiting for raid support, which I've added but am currently debugging ... cf. checklist here; xen support needs nothing further:
vyos/vyos-1x#1768 (comment)

@jestabro jestabro force-pushed the image-tools branch 2 times, most recently from d31792f to e891c1e Compare November 15, 2023 18:13
@jestabro jestabro marked this pull request as ready for review November 16, 2023 19:45
@vyosbot vyosbot requested a review from a team November 16, 2023 19:46
@jestabro jestabro merged commit 80e223c into vyos:current Nov 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-po c-po c-po approved these changes

@sever-sever sever-sever sever-sever approved these changes

@dmbaturin dmbaturin dmbaturin approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

Assignees

@jestabro jestabro

Labels
current VyOS rolling release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jestabro @dmbaturin @sever-sever @c-po