image: T4516: Added system image tools #1768
Conversation
c-po
requested review from
a team,
dmbaturin,
sarthurdev,
jestabro,
sever-sever and
c-po
and removed request for
a team
zdc
changed the title
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
PR's needed for build; draft state until the current one is moved from draft. |
|
Minor fixes in this repo: To be added to this PR when complete. |
|
Comment above and repo updated. |
|
@jestabro as maintainer you can also push to this branch of this PR - just a hint. |
|
Thanks, @c-po ; one minor fix left, at which point I will update the PR repo and open for review. |
|
Has the issue of backward compatibility been resolved? |
|
One can not mange system images from earlier images, after the update, as the grub files have been reorganized. This is a long needed change, so we should discuss the issue. One can consider adding tools to save and rebuild the original grub files for an image, however, moving forward will prevent relying on old tools. |
|
Move to draft for discussion and testing. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This commit adds the whole set of system image tools written from the scratch in Python that allows performing all the operations on images: * check information * perform installation and deletion * versions management Also, it contains a new service that will update the GRUB menu and keep tracking its version in the future. WARNING: The commit contains non-reversible changes. Because of boot menu changes, it will not be possible to manage images from older VyOS versions after an update.
This commit allows management of system images with either new or legacy tools: 'add/delete/rename system image' and 'set default' are translated appropriately on booting between images with the old and new tools. Consequently, the warning of the initial commit of T4516 is dropped.
jestabro
force-pushed
the
T4516-sagitta
branch
from
250b7c8 to
e597509
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
jestabro
force-pushed
the
T4516-sagitta
branch
from
e597509 to
d8b3ae5
Compare
Note that this was updated for the fix in T5739.
An attempt to upgrade to 1.2.x is caught, but error is of failed checksum verification; add check and message.
|
After merging, remaining issues of (1) non-interactive runs of add/delete image, resp. (2) check compatibility with XCP-NG images, will be handled in: |
jestabro
force-pushed
the
T4516-sagitta
branch
from
d8b3ae5 to
e036f78
Compare
Change Summary
Added system image tools
Note that this needs to be merged along with:
vyos/vyatta-op#61
vyos/vyos-build#352
vyos/vyatta-cfg-system#212
for a successful build and image update.
Types of changes
Related Task(s)
Component(s) name
system image
Proposed changes
This commit adds the whole set of system image tools written from the scratch in Python that allows performing all the operations on images:
Also, it contains a new service that will update the GRUB menu and keep tracking its version in the future.
WARNING: The commit contains non-reversible changes. Because of boot menu changes, it will not be possible to manage images from older VyOS versions after an update.
How to test
Checklist: