-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22503 Add support for property Indic_Conjunct_Break #3049
Conversation
4eaab27
to
d243193
Compare
This comment was marked as outdated.
This comment was marked as outdated.
I rebased this PR on top of #3028 . Therefore, this PR:
|
d243193
to
419d617
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOKTM. Do you also have to make changes on the Java side?
Yes, I need the change in Java, since we need a constant (effectively an enum) to represent the new property so that people can provide that vlaue into Although I'm puzzled why that addition of a single line |
Oops! My fault. You do have the Java change in there too. I missed that. But it's just |
Yes indeed! Thanks for catching that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin' good!
The Unicode version constant is not being initialized from the Java resource files. I didn't proceed all the way through in the data update instructions in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing the Java versions of the updated pnames.icu & uprops.icu files, but since the major version number has not changed in this PR, I would expect uprops.icu to still load fine, except that all characters would look like InCB=None.
be896a2
to
f02235a
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
f02235a
to
59fa413
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
FYI --
It was also missing the Java port of the uprops.h / uprops.cpp changes, to UCharacterProperty.java. The class initializer error indicated that an int property had been added (and the _LIMIT constant incremented) without adding an entry to the array of IntProps which defines how to fetch the values for each enumerated property from the data structure. |
This PR is for adding support for property
InCB
(Indic_Conjunct_Break
).Checklist