Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22707 Add support for property Modifier_Combining_Mark #3051

Merged
merged 1 commit into from
Jul 30, 2024
Merged

ICU-22707 Add support for property Modifier_Combining_Mark #3051

merged 1 commit into from
Jul 30, 2024

Conversation

echeran
Copy link
Contributor

@echeran echeran commented Jun 27, 2024 •
edited
Loading

Adds public constants and getter impl code for new property in Unicode 16.0, Modifier_Combining_Mark.

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22707
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@echeran echeran requested a review from markusicu June 27, 2024 23:49
@echeran echeran force-pushed the modifier-combining-mark branch from 902f87e to 031f4e1 Compare June 28, 2024 23:02
@jira-pull-request-webhook

This comment was marked as outdated.

Sign in to view
@echeran
Copy link
Contributor Author

echeran commented Jun 28, 2024

I rebased this PR branch again on top of #3049, after first rebasing #3049 on top of #3028. I may have done something wrong since the unit test utility/UnicodeTest/TestPropertiesUsingPpucd now appears to segfault. Maybe the rebasing somewhere along the way went wrong...please double check carefully.

@echeran echeran force-pushed the modifier-combining-mark branch from 031f4e1 to c7a5be3 Compare July 29, 2024 23:37
@jira-pull-request-webhook

This comment was marked as outdated.

Sign in to view
@echeran echeran force-pushed the modifier-combining-mark branch from dd97c17 to e9ba161 Compare July 30, 2024 04:45
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@echeran echeran marked this pull request as ready for review July 30, 2024 05:15
@echeran echeran merged commit 3663cc1 into unicode-org:main Jul 30, 2024
105 checks passed
@echeran echeran deleted the modifier-combining-mark branch July 30, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@echeran @markusicu