Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-14278 Update Ukrainian-Latin-BGN.xml #3804

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

DJm00n
Copy link
Contributor

@DJm00n DJm00n commented Jun 13, 2024

Fix comments. It is BGN/PCGN 1965 System, not BGN/PCGN 1979.

CLDR-14278

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2024

CLA assistant check
All committers have signed the CLA.

@DJm00n DJm00n changed the title Update Ukrainian-Latin-BGN.xml CLDR-14278 Update Ukrainian-Latin-BGN.xml Jun 13, 2024
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment changes only, LGTM assuming the information is correct.

I did confirm that https://geonames.nga.mil/geonames/GNSSearch/GNSDocs/romanization/ROMANIZATION_OF_UKRAINIAN.pdf references PCGN 1965 not 1979.

@macchiati
Copy link
Member

You'll have to squash this PR, using a comment of the form
CLDR-14278 Update Ukrainian-Latin-BGN.xml

Otherwise the commit message fails validation.

Fix comments. It is BGN/PCGN 1965 System, not BGN/PCGN 1979.
See https://unicode-org.atlassian.net/browse/CLDR-14278
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@DJm00n
Copy link
Contributor Author

DJm00n commented Jun 14, 2024

@macchiati done

@macchiati macchiati merged commit 4e010ff into unicode-org:main Jun 18, 2024
7 checks passed
@DJm00n DJm00n deleted the patch-1 branch June 18, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants