Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dev #558

Merged
merged 248 commits into from
Jun 26, 2024
Merged

Update dev #558

merged 248 commits into from
Jun 26, 2024

Conversation

efaulhaber
Copy link
Member

No description provided.

efaulhaber and others added 30 commits May 26, 2023 16:39
Big refactoring: extract schemes and get rid of container types
…ead of numbering (#161)

* name update instead of numbering

* apply formatter

* fix bug

* change update dispatching

* apply formatter

* implement suggestions

* apply formatter

* implement suggestions
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.14.10 to 1.14.11.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](crate-ci/typos@v1.14.10...v1.14.11)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Erik Faulhaber <[email protected]>
* make update more compact

* move boundary models

* fix `SummationDensity` bug

* implement suggestions

* revert moving compute_density!()

* delete needless function

* add `update!` for `ContinuityDensity`

* fix bug

* add missing pressure
* Restrict JuliaFormatter to 1.0.32 in CI

* Reformat code
* add test

* update

* fixes

* add correction

* simplify

* fix

* update

* change comment

* add correction type

* udate

* fixes

* up

* working

* up

* cleanup

* format

* cleanup

* rename

* merge

* fix

* fix

* fix

* format

* cleanup

* clean

* cleanup

* fix typos

* fix

* fix

* format

* add test

* Update src/sph/corrections.jl

Co-authored-by: Erik Faulhaber <[email protected]>

* Update .typos.toml

Co-authored-by: Erik Faulhaber <[email protected]>

* remove NoCorrection type

* fix cache creation

* comment indent

* fix naming

* format

* merge

* manual merging

* format

* renaming

* renaming

* remove debug

* stupid param order mixup

* Merge branch 'main' into kernel_correction_summation_density

* fix

* fixes

* fix

* format

* fix

* use set zero

* parameter changes

* change name of cache creation function

* remove abstract type

* format

* corrections from review

* revert particle_density changes

* review comments

* review corrections

* review comment

* review comment

* format again

* format

* return boundary_model

---------

Co-authored-by: Erik Faulhaber <[email protected]>
* add viscosity field to boundary models

* extract viscosity calculation

* use viscosity function for `dv_viscosity`

* test formatting

* formatting

* implement suggestions

---------

Co-authored-by: Erik Faulhaber <[email protected]>
Co-authored-by: Erik Faulhaber <[email protected]>
* add test

* update

* fixes

* add correction

* simplify

* fix

* update

* change comment

* add correction type

* udate

* fixes

* up

* working

* up

* cleanup

* format

* cleanup

* rename

* merge

* fix

* fix

* fix

* format

* cleanup

* clean

* cleanup

* fix typos

* fix

* fix

* format

* add test

* add implementation

* fix tests

* fix test setup

* format

* fix tests

* format

* fix tests

* add tests

* format

* Update src/sph/corrections.jl

Co-authored-by: Erik Faulhaber <[email protected]>

* Update .typos.toml

Co-authored-by: Erik Faulhaber <[email protected]>

* remove NoCorrection type

* fix cache creation

* comment indent

* fix naming

* format

* merge fix & format

* merge

* manual merging

* format

* renaming

* renaming

* remove debug

* stupid param order mixup

* Merge branch 'main' into kernel_correction_summation_density

* fix

* fixes

* fix

* format

* fix

* use set zero

* parameter changes

* change name of cache creation function

* remove abstract type

* format

* corrections from review

* revert particle_density changes

* review comments

* review corrections

* manual merge

* manual merge

* fix merge

* fix

* format

* fix test

* format

* fix merge

* fix merge

* fix merge

* fix review comments

* review comments

* format

* rename

* format

* review comments

* review comment

* format

* remove function

* format

* solve review comments

* format

* review comments

* spaces

---------

Co-authored-by: Erik Faulhaber <[email protected]>
* Add more detailed interaction timers

* Implement suggestions

* Fix nbody tests
* add `ViscousInteractionAdami`

* add viscosity dependent velocity

* add wall velocity

* use viscosity function for `dv_viscosity`

* add viscosity function

* fix sign bug

* fix merge conflict

* implement suggestions

* change viscosity naming

* change `create_cache`

* add comments

* implement suggestion

* add tests

* fix docs

* write `wall_velocity`

* apply formatter

* add comments in test

* modify docs

* implement suggestions

* typo in docs

* insert line for consistency

* implement suggestions
Co-authored-by: Erik Faulhaber <[email protected]>
* add test

* update

* fixes

* add correction

* simplify

* fix

* update

* change comment

* add correction type

* udate

* fixes

* up

* working

* up

* cleanup

* format

* cleanup

* rename

* merge

* fix

* fix

* fix

* format

* cleanup

* clean

* cleanup

* fix typos

* fix

* fix

* format

* add test

* add implementation

* fix tests

* fix test setup

* format

* fix tests

* format

* fix tests

* add tests

* format

* add example

* impl

* format

* rename

* fix

* fixes

* fix

* format

* broken

* working

* cleanup

* update test

* update

* format

* Update src/sph/corrections.jl

Co-authored-by: Erik Faulhaber <[email protected]>

* Update .typos.toml

Co-authored-by: Erik Faulhaber <[email protected]>

* remove NoCorrection type

* fix cache creation

* comment indent

* fix allocations

* reducce number of test files

* fix naming

* format

* merge fix & format

* merge

* manual merging

* format

* renaming

* renaming

* remove debug

* merge

* format

* stupid param order mixup

* Merge branch 'main' into kernel_correction_summation_density

* fix

* fixes

* fix

* format

* fix

* use set zero

* parameter changes

* change name of cache creation function

* remove abstract type

* format

* corrections from review

* revert particle_density changes

* review comments

* review corrections

* manual merge

* manual merge

* fix merge

* fix

* format

* fix test

* format

* fix merge

* fix merge

* fix merge

* fix review comments

* review comments

* format

* rename

* format

* review comments

* review comment

* format

* remove function

* format

* solve review comments

* format

* review comments

* spaces

* fix merge errors

* fix merge error

* Merge fix

* manual merge

* format and fix testcase

* rename container to system

* format

* fix testcase

* rename container to system

* format

* rename container to system

* more fixes

* format

* use set_zero

* fix tests

* fix

* fix test

* add doc

* rename

* correct comment

* rename container to system

* reverse merge

* change smoothing kernel calls

* remove additional dw_gamma dispatches

* remove additional kernel_correction_coefficient dispatches

* comments and fix

* format

* review

* Update src/general/corrections.jl

Co-authored-by: Erik Faulhaber <[email protected]>

* Update src/general/general.jl

Co-authored-by: Erik Faulhaber <[email protected]>

* Update src/general/corrections.jl

Co-authored-by: Erik Faulhaber <[email protected]>

* Update src/general/corrections.jl

Co-authored-by: Erik Faulhaber <[email protected]>

* Update src/general/corrections.jl

Co-authored-by: Erik Faulhaber <[email protected]>

* Update src/general/corrections.jl

Co-authored-by: Erik Faulhaber <[email protected]>

* Update src/general/corrections.jl

Co-authored-by: Erik Faulhaber <[email protected]>

* Update src/general/corrections.jl

Co-authored-by: Erik Faulhaber <[email protected]>

* format

---------

Co-authored-by: Erik Faulhaber <[email protected]>
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.14.11 to 1.15.9.
- [Release notes](https://github.com/crate-ci/typos/releases)
- [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md)
- [Commits](crate-ci/typos@v1.14.11...v1.15.9)

---
updated-dependencies:
- dependency-name: crate-ci/typos
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Erik Faulhaber <[email protected]>
#101)

* add ForwardDiff

* add movement function

* add Examples

* adapt example file

* fix typo

* add example description

* rename example file

* rename suggestion

* pass `initial_condition` to `BoundarySPHSystem`

* add comment

* implement suggestions

* fix tests

* move `current_acceleration` to `general/system.jl`
* Fix file overwriting issue with saving callback

* Fix saving callback again

* Undo previous "fix"

* Store iter instead of name
…keep existing compat) (#196)

Co-authored-by: CompatHelper Julia <[email protected]>
* Fix shape sizes

* Fix examples

* Revise constructor

* Fix tests

* Fix tests

* Fix examples

* Fix tests

* Update info messages

* Add `tlsph` kwarg to `RectangularTank`

* Fix tests

* Reformat code

* Revise rectangular tank setup

* Revise `RectangularShape` docs

* Implement suggestion

* Fix tests

* Fix tests

* Fix typos
* fix wall velocity

* adapt tests

* fix tests

* implement suggestions
* First implementation of periodic NHS in 2D

* Add experimental code

* Add example files

* Fix typo

* Make periodicity configurable

* Delete vortex street example (for now)

* Update periodic channel example

* Update boundary model in periodic channel

* Add periodic channel to tests

* Undo `foreach_particle_neighbor` changes

* Reformat code

* Update comments

* Fix `TrivialNeighborhoodSearch` and tests

* Reformat code

* Fix coverage

* Remove debug code

* Implement suggestions

* Remove `current_coordinates` and work with `PeriodicBox`

* Remove periodic box from semi

* Fix semi

* Fix tests

* Fix `TrivialNeighborhoodSearch`

---------

Co-authored-by: LasNikas <[email protected]>
* Implement 3D sphere setup

* Revise `SphereShape` interface

* Fix tests and examples

* Fix asymmetric non-deterministic spheres

* Fix tests

* Add tests for 3D `SphereShape`

* Rename `shape_type` to `sphere_type`

* Rename `layer_inwards` to `layer_outwards`

* Rename `hollow_sphere` to `round_sphere`

* Fix tests

* Add Fibonacci Sphere implementation

* Remove equal area zones implementation

This implementation still had large density singularities
at the poles.

* Fix docs

* Implement pole-optimized zonal equal area distribution

* Remove old implementations

* Implement proper sphere sizes

* Remove layer rotation

* Add comments

* Fix tests

* Add `tlsph` option

* Fix examples

* Improve docs
* Use variable dict indent in JulaFormatter

* Reformat code
LasNikas and others added 27 commits May 6, 2024 10:26
* add `UpdateCallback`

* fix typo

* apply formatter

* remove update bool

* adapt docstring

* implement suggestions

* remove redundant comment
* Move neighborhood search to a new standalone package

* Remove Morton.jl dependency

* Remove tests for neighborhood search

* Remove ThreadingUtilities.jl dependency

* Fix interpolation

* Add docs for neighborhood search

* Dispatch `update_nhs!` instead of `nhs_coords`

* Reformat code

* Update NHS with coordinates of both systems

* Initialize NHS with coordinates of both systems

* Fix broken functions

* Rename package to PointNeighbors.jl

* Reformat code

* Resort Project.toml

* Change PointNeighbors compat to 0.2

* Fix `InitialCondition` set operations

* Fix interpolation and tests

* Fix docs

* Fix example tests

* Fix doctests

* Fix n-body

* Add more comments
* Remove `pinv` in correction matrix inversion step

* Improve comment

* Update validation files for dam break

* Revert "Update validation files for dam break"

This reverts commit d08c06d.

* Update WCSPH validation files

* Update WCSPH validation files

* Add single-threaded validation files (see #481)
* Statically return zero verlocity and acceleration without `movement`

* Make `write_v0!` and `write_u0!` GPU-compatible

* Remove hardcoded float type in rectangular tank setup

* Replace more hardcoded `Float64` types

* Simplify zero SVector even more
* change message

* fix tests

---------

Co-authored-by: Erik Faulhaber <[email protected]>
…rce Surface Tension model (#434)

* merge by hand

* fix merge problems

* fix merge

* fix merge

* fix merge

* fix merge

* fix merge

* more merge fixes

* format

* fix

* fix

* fix

* fix

* fix

* more fixes

* fix

* fix

* fix

* more fixes

* fix

* fix

* format

* running

* update

* update

* optimization

* update

* update

* update

* update

* format

* up

* update

* remove unused code

* switch to support radius

* update

* fix doc

* add adhesion coefficient

* update_broken

* update

* format

* add to examples

* fix tests

* fix merge

* fix typos

* add basic test

* format

* rename

* format

* rename container system

* reduce example run time

* update news and readme

* format

* fix test

* reduce run time

* format

* fix

* correct merge

* update doc test

* revert

* fix tests

* fix

* fix

* review comments

* fix

* fix

* correct some stuff

* init with empty initial condition

* review update

* rename function

* remove unnecessary if

* docs

* fix doc

* revert one change

* fix typo

* update

* try to avoid allocs

* fix mem allocs

* review update

* update docs

* update

* review

* fix

* format

* make examples smaller

* reduce resolution

* review

* rename

* use trixi_include

* format

* use trixi_include

* update

* update

* review update

* format

* fix test errors

* update

* fix surface normal calculation

* adjust testcases and review comments

* update examples

* remove saving interval

* fix comment

* remove dt
* Fix n-body benchmark

* suppress warning

* fix formatting

* for real

---------

Co-authored-by: Sven Berger <[email protected]>
Co-authored-by: Erik Faulhaber <[email protected]>
… GPU (#532)

* Add type `GPUSystem` to determine if a system is stored on the CPU or GPU

* Fix systems and tests

* Reformat

* Fix tests

* Fix n-body system

* Reformat
Bumps [julia-actions/cache](https://github.com/julia-actions/cache) from 1 to 2.
- [Release notes](https://github.com/julia-actions/cache/releases)
- [Changelog](https://github.com/julia-actions/cache/blob/main/devdocs/making_a_new_release.md)
- [Commits](julia-actions/cache@v1...v2)

---
updated-dependencies:
- dependency-name: julia-actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Precompute git hash

* Store git hash in callbacks

* Fix

---------

Co-authored-by: Niklas Neher <[email protected]>
* Move timers and `@trixi_timeit` to TrixiBase.jl

* Require latest version of TrixiBase.jl

* Fix tests

---------

Co-authored-by: Niklas Neher <[email protected]>
* add wrapper

* modify kwarg

* implement suggestions
…ack (#462)

* add example

* replace MSE with MRE

* Revert "replace MSE with MRE"

This reverts commit 1e00907.

* revert

* update

* format

* fix and reduce runtime

* Fix comment

* implement suggestions

* format

---------

Co-authored-by: Erik Faulhaber <[email protected]>
* implement `ExtrudeFace`

* use `sample_face` in `interpolate_plane_3d`

* add docs

* add tests

* fix bug

* create `OpenBoundarySPHSystem`

* export OpenBoundarySPHSystem

* fix bug

* add `tlsph=true`

* fix tuple bug

* fix typo

* fix again

* fix for tests

* fix layers

* calculate particle spacing differently

* add show-tests

* add `within_boundary_zone`

* change `floor` to `ceil`

* boundary zone tests

* add `evaluate_characteristics`

* add tests

* add reference functions

* add `update_quantities!`

* add buffer

* add `SystemBuffer` tests

* cosmetic change in tests

* change `round` to `isapprox`

* add update callback

* add `UpdateCallback`

* add `update_open_boundaries`

* fix bugs

* add timers

* write prescribed quantities

* improve dispatching

* add example `pipe_flow_2d.jl`

* add docs `UpdateCallback`

* add `UpdateCallback`

* fix typo

* apply formatter

* modify system buffer

* add docstring

* add docs

* fix tests

* fix typos

* apply formatter

* fix tests

* add comment

* fix tests

* remove update bool

* adapt docstring

* implement suggestions

* fix test

* add check if callback is used

* add comments in example file

* generic types

* merge main

* undo combining compact support with DEM

* remove density and pressure setter

* implement suggestions

* fix tests

* Revert "remove density and pressure setter"

This reverts commit 0203a3a.

* implement suggestions

* rework in- and outflow

* rename setter functions

* rename function

* adapt tests

* add docs

* rename function

* apply formatter

* fix tests

* fix bug in plot recipes

* apply formatter

* implement suggestions for `boundary_zone.jl`

* rename kwarg

* implement suggestions

* implement suggestions

* modify `check_domain!`

* add comments and check for fluid system with buffer

* modify error message

* fix tests

* fix `callback_used`

* using Measurements

* fix tests

* sqrt(eps())

* fix tests again

* add doc to `boundary.md`

* link single fluid system

* fix tests

* implement suggestions

* fix tests

* change the order of functions

* modify example

* fix tests

* fix test again

* implement doc suggestions

* modify dos

* fix typos

* implement suggestions

* implement suggestions

* add EDAC to the example

* implement suggestions

* modify tests

* adapt docs

* add `initial_callback_flag`

* add to `NEWS.md` and `README.md`

* implement suggestions

* fix typo
Open Boundaries have been added
* Set to development version 0.1.4

* Update Project.toml
* Fix wrapping for GPU arrays

* Adapt `@threaded` macro to work with GPUs

* Use new `@threaded` macro

* Fix NHS to run GPU code with CPU arrays

* Import `@index` from KernelAbstractions.jl

For some reason it doesn't run on the CPU otherwise.

* Add proper docs for `@threaded`

* Fix `foreach_neighbor`

* Reformat

* Add test for GPU code on the CPU

* Fix unit tests

* Add unit tests for GPU interaction

* Also add tests for GPU versions of `wrap_v` and `wrap_u`

* Add kwarg `neighborhood_search` to dam break example

* Fix tests

* Reformat

* Add function `wrap_array`

* Fix merge

* Fix open boundary code

* Implement suggestions

* Fix syntax error from merge

* Fix `wrap_u` and `wrap_v` for GPU array types

* Fix constructor of `BoundarySPHSystem`
…0.9, (keep existing compat) (#551)

Co-authored-by: CompatHelper Julia <[email protected]>
@efaulhaber efaulhaber merged commit 70567b6 into dev Jun 26, 2024
17 checks passed
efaulhaber added a commit that referenced this pull request Jun 26, 2024
This reverts commit 70567b6.
@efaulhaber efaulhaber mentioned this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants