Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(awapi): add velocity factor converter #129

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Nov 21, 2024

PR Type

  • New Feature

Related Links

Description

Add new class to convert message type from autoware_adapi_v1_msgs::msg::VelocityFactorArray to tier4_planning_msgs::msg::StopReasonArray because mainly the former one is being maintained and the latter one is going to be deprecated.

Review Procedure

  1. launch psim
  2. put ego and goal pose
  3. put object in front of the ego
  4. check the topic /awapi/autoware/get/status
  5. it should include following infomation
stop_reason:                                                                                                                                                                                                                                                                                                                                                                                                                    
  header:                                                                                                                                                                                                                                                                                                                                                                                                                       
    stamp:                                                                                                                                                                                                                                                                                                                                                                                                                      
      sec: 1732184395                                                                                                                                                                                                                                                                                                                                                                                                           
      nanosec: 503437096                                                                                                                                                                                                                                                                                                                                                                                                        
    frame_id: map                                                                                                                                                                                                                                                                                                                                                                                                               
  stop_reasons:                                                                                                                                                                                                                                                                                                                                                                                                                 
  - reason: ObstacleStop                                                                                                                                                                                                                                                                                                                                                                                                        
    stop_factors:                                                                                                                                                                                                                                                                                                                                                                                                               
    - stop_pose:                                                                                                                                                                                                                                                                                                                                                                                                                
        position:                                                                                                                                                                                                                                                                                                                                                                                                               
          x: 61608.09100889809                                                                                                                                                                                                                                                                                                                                                                                                  
          y: 56210.605148893905                                                                                                                                                                                                                                                                                                                                                                                                 
          z: 78.12116795304318                                                                                                                                                                                                                                                                                                                                                                                                  
        orientation:                                                                                                                                                                                                                                                                                                                                                                                                            
          x: -4.010359337953184e-05                                                                                                                                                                                                                                                                                                                                                                                             
          y: -0.000754350051703711                                                                                                                                                                                                                                                                                                                                                                                              
          z: -0.05308812400350872                                                                                                                                                                                                                                                                                                                                                                                               
          w: 0.9985895455278356                                                                                                                                                                                                                                                                                                                                                                                                 
      dist_to_stop_pose: 0.182466521859169                                                                                                                                                                                                                                                                                                                                                                                      
      stop_factor_points: []         

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s).
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@satoshi-ota satoshi-ota force-pushed the feat/velocity-factor-converter branch from 6bb88e7 to 61278dd Compare November 21, 2024 10:33
@satoshi-ota satoshi-ota marked this pull request as ready for review November 21, 2024 10:33
Copy link
Collaborator

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stop_reason:
  header:
    stamp:
      sec: 1732268019
      nanosec: 610488996
    frame_id: map
  stop_reasons:
  - reason: ObstacleStop
    stop_factors:
    - stop_pose:
        position:
          x: 3736.294258715315
          y: 73730.87799824534
          z: 19.349823834297794
        orientation:
          x: 0.0001909614396931554
          y: -0.0007789961835898731
          z: 0.23808844437050267
          w: 0.9712431463623866
      dist_to_stop_pose: 7.059513568878174
      stop_factor_points: []

@satoshi-ota satoshi-ota merged commit 6013a40 into tier4/universe Nov 25, 2024
10 checks passed
@satoshi-ota satoshi-ota deleted the feat/velocity-factor-converter branch November 25, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants