Changes to DBus and engine APIs for idempotence #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaublitz
requested review from
mulkieran,
bgurney-rh,
drckeefe and
waltdisgrace
|
It looks like Travis is having trouble, I restarted some tasks. |
|
I was just about to comment on that. It's associated with the previous PR still. It's pulling from the wrong refs. Trying to figure out how to kick off a new build. I think I have to change the commit hash somehow. |
|
That same problem happened to me just once w/ pyudev. |
jbaublitz
force-pushed
the
issue-project-51
branch
from
ed57a38 to
5b9864b
Compare
|
New CI job kicked off. We should be okay now. |
mulkieran
approved these changes
Oct 9, 2019
drckeefe
approved these changes
Oct 9, 2019
mulkieran
requested changes
Oct 9, 2019
waltdisgrace
approved these changes
Oct 9, 2019
Make internal changes to the engine to support idempotent operations over the DBus API so that the return value of DBus methods returns identifiers for resources with state changes and omits resource identifiers where the resources were not changed. Co-Authored-By: mulhern <[email protected]>
jbaublitz
force-pushed
the
issue-project-51
branch
from
5b9864b to
891cb4f
Compare
|
@mulkieran I think I got them all. |
mulkieran
approved these changes
Oct 9, 2019
|
Ok, re-approved. |
bgurney-rh
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1614
Relates to stratis-storage/project#51
Make internal changes to the engine to better support idempotent operations using the DBus API so that the return value of DBus methods provides information on what was changed and omits resources that were not changed.