Jbaublitz issue project 51 #1650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulkieran
force-pushed
the
jbaublitz-issue-project-51
branch
3 times, most recently
from
c7213ec to
15681c5
Compare
…iling per discussion in stratis-storage#1634
It can figure out the type. Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
mulkieran
force-pushed
the
jbaublitz-issue-project-51
branch
from
15681c5 to
5e4ddf6
Compare
It seems to fit in better with its usage. Signed-off-by: mulhern <[email protected]>
Right now it serves no purpose. This is kind of surprising actually, but currently it seems that the code always consumes self, so it makes sense to leave this method out. We can easily add it back in, as necessary. Signed-off-by: mulhern <[email protected]>
It is but lightly used, and in many ways it is better to just consider changed() as the boolean-returning method, just more expressive. Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
Signed-off-by: mulhern <[email protected]>
|
Closed by #1651. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.