Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove @storybook/types dependency in favor of storybook/types/internal #205

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@
"@storybook/csf": "^0.1.11",
"@storybook/docs-tools": "^8.0.0",
"@storybook/node-logger": "^8.0.0",
"@storybook/types": "^8.0.0",
"dedent": "^1.5.3",
"esrap": "^1.2.2",
"lodash-es": "^4.17.21",
Expand Down
12 changes: 0 additions & 12 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/index.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { PlayFunctionContext } from '@storybook/types';
import type { PlayFunctionContext } from 'storybook/internal/types';
import type { Component, ComponentProps, Snippet } from 'svelte';
import type { EmptyObject, Primitive } from 'type-fest';
import { describe, expectTypeOf, it } from 'vitest';
Expand Down
2 changes: 1 addition & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Args as BaseArgs } from '@storybook/types';
import type { Args as BaseArgs } from 'storybook/internal/types';
import dedent from 'dedent';
import type { EmptyObject } from 'type-fest';

Expand Down
2 changes: 1 addition & 1 deletion src/indexer/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import fs from 'node:fs/promises';

import { combineTags } from '@storybook/csf';
import type { IndexInput, Indexer } from '@storybook/types';
import type { IndexInput, Indexer } from 'storybook/internal/types';
import { preprocess } from 'svelte/compiler';

import { getSvelteAST } from '#parser/ast';
Expand Down
2 changes: 1 addition & 1 deletion src/runtime/Story.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
lang="ts"
generics="const TOverrideArgs extends Args, const TCmp extends Cmp, TMeta extends Meta<TCmp>"
>
import type { Args } from '@storybook/types';
import type { Args } from 'storybook/internal/types';
import type { Snippet } from 'svelte';

import { useStoriesExtractor } from '#runtime/contexts/extractor.svelte';
Expand Down
2 changes: 1 addition & 1 deletion src/runtime/contexts/extractor.svelte.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Args } from '@storybook/types';
import type { Args } from 'storybook/internal/types';
import { getContext, hasContext, setContext, type ComponentProps } from 'svelte';

import { storyNameToExportName } from '#utils/identifier-utils';
Expand Down
2 changes: 1 addition & 1 deletion src/runtime/contexts/renderer.svelte.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { getContext, hasContext, setContext } from 'svelte';

import type { Cmp, Meta, StoryAnnotations, StoryContext } from '#types';
import type { Args } from '@storybook/types';
import type { Args } from 'storybook/internal/types';

const CONTEXT_KEY = 'storybook-story-renderer-context';

Expand Down
2 changes: 1 addition & 1 deletion src/runtime/contexts/template.svelte.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Args } from '@storybook/types';
import type { Args } from 'storybook/internal/types';
import { getContext, hasContext, setContext, type ComponentProps } from 'svelte';

import type { Cmp, Meta, StoryCmp } from '#types';
Expand Down
2 changes: 1 addition & 1 deletion src/types.test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { PlayFunctionContext } from '@storybook/types';
import type { PlayFunctionContext } from 'storybook/internal/types';
import type { Component, ComponentProps } from 'svelte';
import { describe, expectTypeOf, it } from 'vitest';

Expand Down
2 changes: 1 addition & 1 deletion src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import type {
StoryAnnotations as BaseStoryAnnotations,
StoryContext as BaseStoryContext,
WebRenderer,
} from '@storybook/types';
} from 'storybook/internal/types';
import type { Component, ComponentProps, Snippet } from 'svelte';
import type { Primitive, SetOptional, Simplify } from 'type-fest';

Expand Down
Loading