Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove @storybook/types dependency in favor of storybook/types/internal #205

Closed
wants to merge 3 commits into from

Conversation

xeho91
Copy link
Collaborator

@xeho91 xeho91 commented Aug 27, 2024

📦 Published PR as canary version: 4.1.7--canary.205.f0ef597.0

✨ Test out this PR locally via:

npm install @storybook/[email protected]
# or 
yarn add @storybook/[email protected]

@JReinhold I need an opinion. We could update storybook and @storybook/* dependencies as drive-by to this PR.
As far I managed to find out, this change (from @storybook/types to storybook/types/internal) was made in v8.2.

@xeho91 xeho91 added patch Increment the patch version when merged prerelease This change is available in a prerelease. labels Aug 27, 2024
@xeho91 xeho91 self-assigned this Aug 27, 2024
@xeho91 xeho91 requested a review from JReinhold August 27, 2024 05:33
@xeho91 xeho91 changed the base branch from main to next August 27, 2024 05:34
@JReinhold
Copy link
Collaborator

It shouldn't make a difference to users, storybook/internal was created in a way that ensures backwards compatibility with 8.0 and @storybook/types. I'd prefer to stay with @storybook/types to keep supporting Storybook 8.0. If we're facing any problems with @storybook/types or storybook/internal, we should fix that upstream instead, since that will probably also cause problems for other addons.

@xeho91
Copy link
Collaborator Author

xeho91 commented Aug 27, 2024

No objection, good points. Closing this PR then.

@xeho91 xeho91 closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged prerelease This change is available in a prerelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants