Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover if crashing between posting root msg and adding self to group #56

Merged
merged 7 commits into from
Feb 9, 2023

Conversation

Powersource
Copy link
Collaborator

for #40

@Powersource
Copy link
Collaborator Author

Added a failing test

ok 19 there is 1 used group feed and 1 we created now with a root message but not ourselves as a member
not ok 20 there are still only 2 group feeds after creating another group. the unused one got used by create()
  ---
    operator: equal
    expected: 2
    actual:   3
    at: <anonymous> (/home/me/prj/ssb/ssb-tribes2/test/create.test.js:243:25)

@Powersource Powersource marked this pull request as ready for review February 8, 2023 19:29
@Powersource Powersource requested review from staltz and mixmix February 8, 2023 19:30
@Powersource
Copy link
Collaborator Author

aah a test is failing

index.js Show resolved Hide resolved
@Powersource Powersource marked this pull request as draft February 8, 2023 19:57
@Powersource Powersource marked this pull request as ready for review February 9, 2023 09:20
@Powersource
Copy link
Collaborator Author

@staltz @mixmix fixed tests!

Copy link
Member

@staltz staltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. The implementation is getting trickier, and maybe eventually it'll make sense to create easy APIs to query groups and our group feeds, but no need to anticipate that right now

@Powersource Powersource merged commit 4beef23 into master Feb 9, 2023
@Powersource Powersource deleted the crash-before-add-self branch February 9, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants