-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init should also be encrypted to self #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm not an expert in this repo
i guess i'm curious if "to yourself" should be specified further or if we leave that to the actual encryption parts of the spec(s) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as other PR - using own_key, or we link to part of spec that is relevnt
i'm confused what own_key means, i can only find it mentioned here https://github.com/ssbc/private-group-spec/blob/master/direct-messages/README.md and it's very brief. It says
but how does that mapping work? |
group/init/README.md
Outdated
vat msg_key = ... make up a one use key for the msg | ||
var group_key = ... symmetric key as buffer | ||
var own_key = ... symmetric key as buffer | ||
var msg_key = ... make up a one use key for the msg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 this needs to be changed to clarify:
var group_key = { key, scheme: 'xxxxx' } // key is symmetric key as buffer
var own_key = { key, scheme: 'yyyy' } // key is a symmetric key as a buffer
var msg_key = ... make up a one use key for the msg as a buffer
put in actual strings for xxxxx, yyyyy
And check what I'm saying makes sense in the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
envelopejs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have no idea how own_key
works and it's not really documented, how would i explain it to someone else lol? Different PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be in a clearer space but some of these ideas have evolved as we've used them and talked about them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i fixed this now
looks perfect |
for ssbc/ssb-tribes2#40
implemented in ssbc/ssb-tribes2#56