Warn on spaces in module names #426
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sol
force-pushed
the
warn-on-invalid-modules
branch
from
b7b1649 to
7c25383
Compare
andreasabel
reviewed
Jan 21, 2021
| Foo | ||
| Bar | ||
| Baz | ||
| |] `shouldWarn` ["package.yaml: invalid module name \"Foo Bar Baz\" in $.library.other-modules"] |
There was a problem hiding this comment.
Couldn't users be surprised that they are warned about an invalid module name, but then things "work fine" in the sense that a working cabal-file is produced?
#421 (comment)
So maybe the warning should add that things might work by accident nevertheless, but in the future this behavior will not be supported any more.
There was a problem hiding this comment.
Yes, I think you have a point. I think what we want is tell the user what to do (say turn it into a YAML list). I'll look into it.
sol
force-pushed
the
warn-on-invalid-modules
branch
from
7c25383 to
f9f91b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.