Warn on spaces in module names

sol · Jan 20, 2021 · 7c25383 · 7c25383
1 parent 9f0b49b
commit 7c25383
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/Hpack/Module.hs b/src/Hpack/Module.hs
@@ -33,7 +33,11 @@ instance IsString Module where
   fromString = Module
 
 instance FromValue Module where
-  fromValue = fmap Module . fromValue
+  fromValue v = do
+    r <- fromValue v
+    case words r of
+      [name] -> return (Module name)
+      _ -> warn ("invalid module name " ++ show r) >> return (Module r)
 
 toModule :: Path -> Module
 toModule path = case reverse $ Path.components path of

diff --git a/test/EndToEndSpec.hs b/test/EndToEndSpec.hs
@@ -70,6 +70,17 @@ spec = around_ (inTempDirectoryNamed "foo") $ do
           "package.yaml: Duplicate field $.name"
         ]
 
+    context "when a module name contains spaces" $ do
+      it "warns" $ do
+        [i|
+        name: foo
+        library:
+          other-modules:
+            Foo
+            Bar
+            Baz
+        |] `shouldWarn` ["package.yaml: invalid module name \"Foo Bar Baz\" in $.library.other-modules"]
+
     describe "handling of Paths_ module" $ do
       it "adds Paths_ to other-modules" $ do
         [i|