-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: display lending positions post-hardfork shenanigans #7747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retested both with a known borrower: and with my own addy (no loans atm): and couldn't repro. @0xApotheosis is this happening deterministically for you? 🤔 |
gm @0xApotheosis! 2d0e08f Confirmed this was an actual bug - non-lending enabled pools will error, which we should not fetch (and did not previously) but now will as we lost the ability to narrow our collateral pools proper - at least when fetching positions - "Available Pools" is still happy (though not user-facing happy as pools are still full upstream as they've been for many months!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gm indeed @gomesalexandre! My loans are great again 😌
Description
Does precisely what it says on the box.
NOTE: While this fixes displaying positions, repays still can't be done because of close endpoint shenanigans: https://discord.com/channels/838986635756044328/1283906886051172427/1284230662517424254
Issue (if applicable)
closes N/A
Risk
Low - ensure "Available Pools" is still displaying no pools
Testing
Engineering
Operations
Screenshots (if applicable)