Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: display all pools in lending "Available Pools" #7754

Merged
merged 2 commits into from
Sep 17, 2024
Merged

fix: display all pools in lending "Available Pools" #7754

merged 2 commits into from
Sep 17, 2024
+35 −14

Conversation

gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Sep 16, 2024 •
edited
Loading

Description

Two birds one stone:

Issue (if applicable)

N/A

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low

Testing

  • Ensure both pools are displayed in lending's "Available Pools"
  • Ensure "Your Positions" tab is still happy

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

Tested against develop (right):

Screenshot 2024-09-16 at 14 59 34 Screenshot 2024-09-16 at 14 59 47

@gomesalexandre gomesalexandre requested a review from a team as a code owner September 16, 2024 11:03
kaladinlight
kaladinlight approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@kaladinlight kaladinlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and sounds sane to me. Thanks!

@kaladinlight kaladinlight enabled auto-merge (squash) September 17, 2024 18:12
@kaladinlight kaladinlight merged commit 5bbb9fb into develop Sep 17, 2024
3 checks passed
@kaladinlight kaladinlight deleted the feat_lending_improvements_yourPositions branch September 17, 2024 18:23
@0xApotheosis 0xApotheosis mentioned this pull request Sep 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaladinlight kaladinlight kaladinlight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomesalexandre @kaladinlight