fix: generateRelatedAssetIndex not running due to ethers hdwallet import woes #7744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+36
to
+48
| // Redeclared here due to ethers import issues | ||
| export const EVM_CHAIN_IDS = [ | ||
| KnownChainIds.EthereumMainnet, | ||
| KnownChainIds.AvalancheMainnet, | ||
| KnownChainIds.OptimismMainnet, | ||
| KnownChainIds.BnbSmartChainMainnet, | ||
| KnownChainIds.PolygonMainnet, | ||
| KnownChainIds.GnosisMainnet, | ||
| KnownChainIds.ArbitrumMainnet, | ||
| KnownChainIds.ArbitrumNovaMainnet, | ||
| KnownChainIds.BaseMainnet, | ||
| ] as const | ||
|
|
There was a problem hiding this comment.
FYI @woodenfurniture I actually did the exact same in #7736 (comment) for the same reason - going to nuke all chain-adapters consumptions and leverage utils only in a follow-up 🙏🏽
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes CI job to regenerate the asset list. Was broken due to import issues related to ethers in hdwallet which is unrelated to this script.
The failure was introduced in #7697 where we're importing
@shapeshiftoss/hdwallet-ledgerwhich relies on ethers. Decided to re-delate the EVM chain list rather than invest the hours in ethers+hdwallet imports.Issue (if applicable)
NA
Risk
Low risk.
Testing
I've re-run the generate asset list scripts per
.github/workflows/generate.yml, and committed the changes.Engineering
Operations
Screenshots (if applicable)