-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: markets page recommended tab and Portals assets #7736
Conversation
Opening for early review - still some cleanup and small additions tbd here and oil to be bearded, this looks jank visually atm but the guts are here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩸Love to see so much red ser. Couple q's but code wise looking 🩸🩸🩸 (good)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise looking good, though found a couple of strange things, unsure which ones are strictly blocking since this is WIP.
Testing notes
❓ Markets page icon same as pools page
❓ Chain selection affects other rows
https://jam.dev/c/8ea1bf53-10d4-462d-a1e6-953b59d71ec6
❌ Empty chain entry in drop-down leading to empty page
Replaced with the same as the Assets page to match the spec - 7dfee08 :
Decoupled selection per row in 78d258f, nice catch!
Filtered out Arb nova in 8f83532 Also on a tengent re: two last line items, added a notion of supported ChainIds in 81f9492 as well as a narrowing of Portals assets at queryparams time- this will
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aww yeah baby now I can look at the top moving base assets while enjoying looking at the trending arbitrum assets 🐐
Description
This PR brings in the recommended tab of markets page, alongside Portals tokens fetching.
TODO:
Follow-up:
Beard-oildisregard this, this was @NeOMakinG oil, he may not have a beard, but the oil is of the highest quality tooIssue (if applicable)
Risk
Low
Testing
Engineering
Operations
Screenshots (if applicable)