shader_recompiler: Improvements to buffer addressing implementation.

[squidbus]

Adds a new common buffer addressing implementation, accounting for all of the different components:

• Fixes handling of index_stride and element_size which need to be converted into their actual value from bit field.
• Texture buffers still have some limitations, asserted on specially before calling this new function.
• Parameters from sharp needed for swizzle_enable added to specialization.

And misc related improvements:

• Add multiply by 1 case to constant propagation pass to help optimize new buffer address logic.
• Clean up buffer load/store instructions to pass through all the MUBUF/MTBUF flags and let the tracking pass take care of what is and isn't supported in one place.

Fixes some shaders in CUSA05637 that use swizzle addressing.

[rafael-57]

Since I saw swizzle changes I tested for #1858, no changes for that issue.

[squidbus]

Since I saw swizzle changes I tested for #1858, no changes for that issue.

Different kind of swizzle.

[diegolix29]

im having like 3 fps less on dlc BB with this pr but dont now it maybe load to pc but tested on main and the fps where more by 3-4 i know is not a big difference but its the only thing i noticed changed with this pr on bb

i9 intel 12900k
nvidia 3080 12gb
64 Ram
windows 10

[squidbus]

im having like 3 fps less on dlc BB with this pr but dont now it maybe load to pc but tested on main and the fps where more by 3-4 i know is not a big difference but its the only thing i noticed changed with this pr on bb

If I had to guess any differences to performance should be either down to shader recompiles because of the changes which would be temporary as your GPU driver shader cache updates, or due to specialization fixes making more variants which is unavoidable for correctness.

[squidbus]

I removed the uniform size fix for specialization for now as I'm still having some issues with excessive shader recompiles from buffer sizes, now it's just the buffer addressing changes.

[meijjaa]

Hi Squidbus, thanks for the hard word so far!
I was just testing with CUSA03745 v1.03 and noticed the
"Unsupported texture buffer address mode." Assert due to swizzle_enable == 1. Is this something you'll be working on? Or can I help in any way? I have setup a debug environment for easy testing.

[squidbus]

Hi Squidbus, thanks for the hard word so far! I was just testing with CUSA03745 v1.03 and noticed the "Unsupported texture buffer address mode." Assert due to swizzle_enable == 1. Is this something you'll be working on? Or can I help in any way? I have setup a debug environment for easy testing.

It's going to require a lot more work to implement the rest of addressing for texture buffers, since we can't offset them at the sub-texel level.

[ArbestRi02]

we should rebase again
the hedgehog engine 2 post processing fix has been added to main

[squidbus]

we should rebase again

Sure, done