Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderer_vulkan: Handle depth-stencil copies through depth render overrides. #2134

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

squidbus
Copy link
Collaborator

@squidbus squidbus commented Jan 12, 2025

As noted in the AMD docs, DB_RENDER_OVERRIDE bits may be used to perform copies to alternate surfaces. Detect and implement this case by looking for these bits set along with a valid depth/stencil read/write base and disabled color buffer mode.

Fixes a lot of post-processing issues in Hedgehog Engine 2 games, such as persistent screen overlays (supposed to be an effect over objects far in the distance) and incorrect lighting effects (although there are still some other lighting problems remaining). Probably helps other games that do this as well.

@dbz400
Copy link
Contributor

dbz400 commented Jan 12, 2025

Sonic Forces no more blurred in-game and combine with #2123 , it is fully playable.

image

@jas0n098
Copy link
Contributor

Breaks Fist of the North Star: Lost Paradise by making nearly everything transparent/invisible
2134

@roamic
Copy link
Collaborator

roamic commented Jan 12, 2025

FotNS:LP is not working without a hack so you can't really break it.

@roamic
Copy link
Collaborator

roamic commented Jan 12, 2025

That being said, FotNS:LP crashes on my system now (NV 4080 12 Gb, i7 8700, 32 Gb DDR4). It doesn't crash on main, so it's a regression.

@tomboylover93
Copy link
Contributor

This fixes the visibility issue in the Radical Highway section of the first stage in SONIC X SHADOW GENERATIONS (CUSA44422), making it fully playable from start to finish.

Screenshot_20250112_103730

@roamic
Copy link
Collaborator

roamic commented Jan 13, 2025

FotNS:LP crash regression if fixed with the latest commit.

@squidbus
Copy link
Collaborator Author

Removed changes to depth buffer read/write base and just implements the special depth-stencil copy now.

@roamic roamic merged commit 5040be1 into shadps4-emu:main Jan 15, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants