-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rz-test '-y' option to accept all #4772
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you want this -y
option?
Because sometimes changing some of rzil's code creates a large number of changes |
Do you have an example of that? ... sorry not that keen on adding code that has to be manually tested and is not strictly necessary |
For example, in this commit, I used this feature to automatically ACCEPT over 200 asm tests at a time. Well, if I'm the only one who uses this feature, then it's okay to turn off the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's actually easy to create a test for this @kazarmy - there is test/unit/test_rz_test.c
Well actually it's not because whether it can be tested automatically, it's because I don't think blind fixing should be encouraged, but I suppose it's fine as long as it's used responsibly |
c337c0d
to
8856959
Compare
* Add rz-test '-y' option to accept all * Add '-y' into the help text
chore:updated rz_core_asm_plugins_print to have flag arguments add optional flags support to rz_core_asm_plugins_print add feature argument add features argument rz-test: add `-y` option to accept all (rizinorg#4772) * Add rz-test '-y' option to accept all * Add '-y' into the help text add clang format correct Laj output to have features other than ad add tests for filtering La add tests for filtering Laq add tests for filtering Laj clang format rz-test: add `-y` option to accept all (rizinorg#4772) * Add rz-test '-y' option to accept all * Add '-y' into the help text dbtj: Add space between flags in `desc` property (rizinorg#4790) subprojects: update rz-libdemangle (rizinorg#4791) Remove trailing space in dbg_trace test (rizinorg#4792) merge the filtering tests add clang format Remove trailing space in dbg_trace test (rizinorg#4792) rzil: add VM event memory (read|write) index (rizinorg#4789) This is because the memory of the RzIL VM has an index, but the index is ignored when an event is generated. revert changes
Your checklist for this pull request
Detailed description
...
Test plan
...
Closing issues
...