Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rzil 'fexcept'|'FEXCEPT' #4771

Merged
merged 4 commits into from
Dec 18, 2024
Merged

add rzil 'fexcept'|'FEXCEPT' #4771

merged 4 commits into from
Dec 18, 2024

Conversation

imbillow
Copy link
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

Add a new rzil op for getting floating point exceptions

Test plan

...

Closing issues

...

@imbillow imbillow mentioned this pull request Dec 16, 2024
Merged
5 tasks
wargio
wargio approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@wargio wargio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense, but i think those should be handled like for div0.

see rz_il_handler_div

XVilka
XVilka requested changes Dec 16, 2024
View reviewed changes
librz/il/il_opcodes.c Outdated Show resolved Hide resolved
wargio
wargio reviewed Dec 17, 2024
View reviewed changes
librz/il/theory_fbasic.c Outdated Show resolved Hide resolved
wargio
wargio requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@wargio wargio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous comment

XVilka
XVilka requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please add a test also
  2. Please rebase to fix the CI

@XVilka
Copy link
Member

XVilka commented Dec 17, 2024

@thestr4ng3r could you please give a quick look?

@XVilka XVilka merged commit 801f2ac into dev Dec 18, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wargio wargio wargio approved these changes

@XVilka XVilka XVilka approved these changes

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

Assignees
No one assigned
Labels
API rz-test RZIL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imbillow @XVilka @wargio