Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #44

Merged
merged 6 commits into from
Nov 28, 2024
Merged

Fix tests #44

merged 6 commits into from
Nov 28, 2024

Conversation

tgross03
Copy link
Contributor

  • Fixed random number drawing in tests by changing the location of the seed override

@tgross03 tgross03 requested review from Kevin2 and aknierim November 14, 2024 13:30
@tgross03
Copy link
Contributor Author

tgross03 commented Nov 14, 2024

Looks like the seed lead to continuous failing of tests. Changed from 1337 to 42

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.28%. Comparing base (05c9809) to head (d38601d).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pyvisgen/simulation/data_set.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   83.82%   86.28%   +2.45%     
==========================================
  Files          13       13              
  Lines         841      853      +12     
==========================================
+ Hits          705      736      +31     
+ Misses        136      117      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tgross03 tgross03 linked an issue Nov 14, 2024 that may be closed by this pull request
@tgross03 tgross03 merged commit 94fe38f into main Nov 28, 2024
6 checks passed
@tgross03 tgross03 deleted the fix_tests branch November 28, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests sometimes fail with TypeError when creating observation object
2 participants