Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests sometimes fail with TypeError when creating observation object #42

Closed
aknierim opened this issue Oct 25, 2024 · 2 comments · Fixed by #44
Closed

Tests sometimes fail with TypeError when creating observation object #42

aknierim opened this issue Oct 25, 2024 · 2 comments · Fixed by #44

Comments

@aknierim
Copy link
Member

aknierim commented Oct 25, 2024 •
edited
Loading

The simulation unit tests in tests/test_simulation.py sometimes fail with

tests/test_simulation.py::test_vis_loop - TypeError: scalar 'Time' object is not iterable.

So somewhere the Observation class seems to try and iterate over a scalar, i.e. single value, Time object.
@Kevin2
Copy link
Member

Kevin2 commented Oct 25, 2024

it is because our random seeds are not set correctly
sometimes the wrong seed leads to a observation config where the source is not visible

@aknierim
Copy link
Member Author

Ah, that makes sense, thank you

@tgross03 tgross03 linked a pull request Nov 14, 2024 that will close this issue
Fix tests #44
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tests radionets-project/pyvisgen
2 participants
@Kevin2 @aknierim