[tests][auth] Fix unreported issue with auth tests skipped, fix storage of ssl protocol #57981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test were silently skipped since 5ac1774 (lazy init of auth manager). The error message was also misleading: "QCA's qca-ossl plugin is missing, skipping test case" because the plugin was actually installed but the auth system wasn't initialized.
The old approach (casting Qt enums to int and storing) is not stable, and breaks with the Qt 6 builds were the raw SSL protocol enums have changed values (due to removed deprecated protocols). Replace this with a stable string encoding/decoding approach, with compatibility for upgrading older configus, and add additional tests. (Note that auth configuration created in Qt 5 builds which use the deprecated protocols cannot be loaded in Qt 6 builds, since those protocols are no longer supported.)
nyalldawson
force-pushed
the
bugfix-authmanager-initialization-in-tests
branch
from
18b0f6e to
62515d0
Compare
elpaso
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #57890, adding the required changes to fix the tests on Qt 6 builds.
The old approach (casting Qt enums to int and storing) is not stable, and breaks with the Qt 6 builds were the raw SSL protocol
enums have changed values (due to removed deprecated protocols).
Replace this with a stable string encoding/decoding approach, with compatibility for upgrading older configus, and add additional tests.
(Note that auth configuration created in Qt 5 builds which use the deprecated protocols cannot be loaded in Qt 6 builds, since
those protocols are no longer supported.)