[tests][auth] Fix unreported issue with auth tests skipped #57890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test were silently skipped since 5ac1774 (lazy init of auth manager). The error message was also misleading: "QCA's qca-ossl plugin is missing, skipping test case" because the plugin was actually installed but the auth system wasn't initialized.
elpaso
added
Authentication
nyalldawson
approved these changes
Jun 26, 2024
|
Superseded by #57981 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test were silently skipped since 5ac1774 (lazy init of auth manager).
The error message was also misleading:
"QCA's qca-ossl plugin is missing, skipping test case" because the plugin was actually installed but the auth system wasn't initialized.