Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync .pyre_configuration.external files for those that got out of sync with last upgrade #943

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pyre_configuration
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@
"stubs"
],
"strict": true,
"version": "0.0.101709640814"
"version": "0.0.101721906040"
}
2 changes: 2 additions & 0 deletions torchx/examples/apps/tracker/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ def test(
for data, target in test_loader:
data, target = data.to(device), target.to(device)
output = model(data)
# pyre-fixme[58]: `+` is not supported for operand types `int` and
# `Union[bool, float, int]`.
test_loss += F.nll_loss(
output, target, reduction="sum"
).item() # sum up batch loss
Expand Down
4 changes: 3 additions & 1 deletion torchx/pipelines/kfp/adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ def component_spec_from_app(app: api.AppDef) -> Tuple[str, api.Role]:

role = app.roles[0]
assert (
role.num_replicas == 1
role.num_replicas
== 1
# pyre-fixme[16]: `AppDef` has no attribute `num_replicas`.
), f"KFP adapter only supports one replica, got {app.num_replicas}"

command = [role.entrypoint, *role.args]
Expand Down
2 changes: 2 additions & 0 deletions torchx/schedulers/aws_batch_scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -809,6 +809,8 @@ def _stream_events(
startFromHead=True,
**args,
)
# pyre-fixme[66]: Exception handler type annotation `unknown` must
# extend BaseException.
except self._log_client.exceptions.ResourceNotFoundException:
return [] # noqa: B901
if response["nextForwardToken"] == next_token:
Expand Down
Loading