Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync .pyre_configuration.external files for those that got out of sync with last upgrade #943

Closed
wants to merge 1 commit into from

Conversation

connernilsen
Copy link
Contributor

Summary:
This downgrades the .pyre_configurations in the following projects to keep their internal and external configurations synced.

  • beanmachine/beanmachine/ppl
  • tools/sapp
  • torchrec
  • torchx

The versions were chosen to match the most recent Pyre version in pyre-check-nightly.

Differential Revision: D61211101

…c with last upgrade

Summary:
This downgrades the .pyre_configurations in the following projects to keep their internal and external configurations synced.
- beanmachine/beanmachine/ppl
- tools/sapp
- torchrec
- torchx

The versions were chosen to match the most recent Pyre version in [pyre-check-nightly](https://pypi.org/project/pyre-check-nightly/#history).

Differential Revision: D61211101
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 13, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61211101

Copy link
Contributor

@tonykao8080 tonykao8080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

@tonykao8080 tonykao8080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyre is failing. unapprove until signal pass

Copy link
Contributor

@yikaiMeta yikaiMeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

connernilsen added a commit to connernilsen/torchrec that referenced this pull request Aug 14, 2024
…c with last upgrade (pytorch#2294)

Summary:
Pull Request resolved: pytorch#2294

X-link: pytorch/torchx#943

This downgrades the .pyre_configurations in the following projects to keep their internal and external configurations synced.
- beanmachine/beanmachine/ppl
- tools/sapp
- torchrec
- torchx

The versions were chosen to match the most recent Pyre version in [pyre-check-nightly](https://pypi.org/project/pyre-check-nightly/#history).

Differential Revision: D61211101
connernilsen added a commit to connernilsen/torchrec that referenced this pull request Aug 15, 2024
…c with last upgrade (pytorch#2294)

Summary:
Pull Request resolved: pytorch#2294

X-link: pytorch/torchx#943

This downgrades the .pyre_configurations in the following projects to keep their internal and external configurations synced.
- beanmachine/beanmachine/ppl
- tools/sapp
- torchrec
- torchx

The versions were chosen to match the most recent Pyre version in [pyre-check-nightly](https://pypi.org/project/pyre-check-nightly/#history).

Differential Revision: D61211101
facebook-github-bot pushed a commit to facebook/sapp that referenced this pull request Aug 15, 2024
…c with last upgrade

Summary:
X-link: pytorch/torchrec#2294

X-link: pytorch/torchx#943

This downgrades the .pyre_configurations in the following projects to keep their internal and external configurations synced.
- beanmachine/beanmachine/ppl
- tools/sapp
- torchrec
- torchx

The versions were chosen to match the most recent Pyre version in [pyre-check-nightly](https://pypi.org/project/pyre-check-nightly/#history).

Reviewed By: grievejia

Differential Revision: D61211101

fbshipit-source-id: a491da274c65d6001d893a0ea559d781f970c9e8
facebook-github-bot pushed a commit to pytorch/torchrec that referenced this pull request Aug 15, 2024
…c with last upgrade (#2294)

Summary:
Pull Request resolved: #2294

X-link: pytorch/torchx#943

This downgrades the .pyre_configurations in the following projects to keep their internal and external configurations synced.
- beanmachine/beanmachine/ppl
- tools/sapp
- torchrec
- torchx

The versions were chosen to match the most recent Pyre version in [pyre-check-nightly](https://pypi.org/project/pyre-check-nightly/#history).

Reviewed By: grievejia

Differential Revision: D61211101

fbshipit-source-id: a491da274c65d6001d893a0ea559d781f970c9e8
PaulZhang12 pushed a commit to pytorch/torchrec that referenced this pull request Aug 19, 2024
…c with last upgrade (#2294)

Summary:
Pull Request resolved: #2294

X-link: pytorch/torchx#943

This downgrades the .pyre_configurations in the following projects to keep their internal and external configurations synced.
- beanmachine/beanmachine/ppl
- tools/sapp
- torchrec
- torchx

The versions were chosen to match the most recent Pyre version in [pyre-check-nightly](https://pypi.org/project/pyre-check-nightly/#history).

Reviewed By: grievejia

Differential Revision: D61211101

fbshipit-source-id: a491da274c65d6001d893a0ea559d781f970c9e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants