Skip to content
GitHub Actions / Clippy (1.56.1) failed Apr 25, 2024 in 0s

Clippy (1.56.1)

6 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 6
Warning 0
Note 0
Help 0

Versions

  • rustc 1.73.0 (cc66ad468 2023-10-03)
  • cargo 1.73.0 (9c4383fb5 2023-08-26)
  • clippy 0.1.73 (cc66ad4 2023-10-03)

Annotations

Check failure on line 67 in halo2_backend/src/poly/kzg/strategy.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

this lifetime isn't used in the impl

error: this lifetime isn't used in the impl
  --> halo2_backend/src/poly/kzg/strategy.rs:67:6
   |
67 | impl<'params, E> AccumulatorStrategy<E>
   |      ^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes

Check failure on line 44 in halo2_backend/src/poly/kzg/strategy.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

this lifetime isn't used in the impl

error: this lifetime isn't used in the impl
  --> halo2_backend/src/poly/kzg/strategy.rs:44:6
   |
44 | impl<'params, E> GuardKZG<E>
   |      ^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes

Check failure on line 33 in halo2_backend/src/poly/kzg/strategy.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

this lifetime isn't used in the impl

error: this lifetime isn't used in the impl
  --> halo2_backend/src/poly/kzg/strategy.rs:33:6
   |
33 | impl<'params, E> Guard<KZGCommitmentScheme<E>> for GuardKZG<E>
   |      ^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes

Check failure on line 171 in halo2_backend/src/poly/kzg/msm.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

you should consider adding a `Default` implementation for `DualMSM<E>`

error: you should consider adding a `Default` implementation for `DualMSM<E>`
   --> halo2_backend/src/poly/kzg/msm.rs:166:5
    |
166 | /     pub fn new() -> Self {
167 | |         Self {
168 | |             left: MSMKZG::new(),
169 | |             right: MSMKZG::new(),
170 | |         }
171 | |     }
    | |_____^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
    = note: `-D clippy::new-without-default` implied by `-D warnings`
help: try adding this
    |
160 + impl<E: MultiMillerLoop> Default for DualMSM<E> {
161 +     fn default() -> Self {
162 +         Self::new()
163 +     }
164 + }
    |

Check failure on line 69 in halo2_backend/src/poly/kzg/commitment.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

this expression creates a reference which is immediately dereferenced by the compiler

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> halo2_backend/src/poly/kzg/commitment.rs:69:28
   |
69 |         Self::write_custom(&self, writer, SerdeFormat::RawBytes)
   |                            ^^^^^ help: change this to: `self`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `-D clippy::needless-borrow` implied by `-D warnings`

Check failure on line 43 in halo2_backend/src/plonk/keygen.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (1.56.1)

this lifetime isn't used in the function definition

error: this lifetime isn't used in the function definition
  --> halo2_backend/src/plonk/keygen.rs:43:18
   |
43 | pub fn keygen_vk<'params, C, P>(
   |                  ^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
   = note: `-D clippy::extra-unused-lifetimes` implied by `-D warnings`