Skip to content

refactor: fix TODOs & leftover #482

refactor: fix TODOs & leftover

refactor: fix TODOs & leftover #482

Triggered via push April 25, 2024 16:41
Status Success
Total duration 59s
Artifacts

lints-beta.yml

on: push
Clippy (beta)
49s
Clippy (beta)
Fit to window
Zoom out
Zoom in

Annotations

6 errors and 19 warnings
this lifetime isn't used in the impl: halo2_backend/src/poly/kzg/strategy.rs#L67
error: this lifetime isn't used in the impl --> halo2_backend/src/poly/kzg/strategy.rs:67:6 | 67 | impl<'params, E> AccumulatorStrategy<E> | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
this lifetime isn't used in the impl: halo2_backend/src/poly/kzg/strategy.rs#L44
error: this lifetime isn't used in the impl --> halo2_backend/src/poly/kzg/strategy.rs:44:6 | 44 | impl<'params, E> GuardKZG<E> | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
this lifetime isn't used in the impl: halo2_backend/src/poly/kzg/strategy.rs#L33
error: this lifetime isn't used in the impl --> halo2_backend/src/poly/kzg/strategy.rs:33:6 | 33 | impl<'params, E> Guard<KZGCommitmentScheme<E>> for GuardKZG<E> | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
you should consider adding a `Default` implementation for `DualMSM<E>`: halo2_backend/src/poly/kzg/msm.rs#L166
error: you should consider adding a `Default` implementation for `DualMSM<E>` --> halo2_backend/src/poly/kzg/msm.rs:166:5 | 166 | / pub fn new() -> Self { 167 | | Self { 168 | | left: MSMKZG::new(), 169 | | right: MSMKZG::new(), 170 | | } 171 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `-D clippy::new-without-default` implied by `-D warnings` help: try adding this | 160 + impl<E: MultiMillerLoop> Default for DualMSM<E> { 161 + fn default() -> Self { 162 + Self::new() 163 + } 164 + } |
this expression creates a reference which is immediately dereferenced by the compiler: halo2_backend/src/poly/kzg/commitment.rs#L69
error: this expression creates a reference which is immediately dereferenced by the compiler --> halo2_backend/src/poly/kzg/commitment.rs:69:28 | 69 | Self::write_custom(&self, writer, SerdeFormat::RawBytes) | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-D clippy::needless-borrow` implied by `-D warnings`
this lifetime isn't used in the function definition: halo2_backend/src/plonk/keygen.rs#L43
error: this lifetime isn't used in the function definition --> halo2_backend/src/plonk/keygen.rs:43:18 | 43 | pub fn keygen_vk<'params, C, P>( | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes = note: `-D clippy::extra-unused-lifetimes` implied by `-D warnings`
this lifetime isn't used in the impl: halo2_backend/src/poly/kzg/strategy.rs#L67
warning: this lifetime isn't used in the impl --> halo2_backend/src/poly/kzg/strategy.rs:67:6 | 67 | impl<'params, E> AccumulatorStrategy<E> | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
this lifetime isn't used in the impl: halo2_backend/src/poly/kzg/strategy.rs#L44
warning: this lifetime isn't used in the impl --> halo2_backend/src/poly/kzg/strategy.rs:44:6 | 44 | impl<'params, E> GuardKZG<E> | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
this lifetime isn't used in the impl: halo2_backend/src/poly/kzg/strategy.rs#L33
warning: this lifetime isn't used in the impl --> halo2_backend/src/poly/kzg/strategy.rs:33:6 | 33 | impl<'params, E> Guard<KZGCommitmentScheme<E>> for GuardKZG<E> | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
you should consider adding a `Default` implementation for `DualMSM<E>`: halo2_backend/src/poly/kzg/msm.rs#L166
warning: you should consider adding a `Default` implementation for `DualMSM<E>` --> halo2_backend/src/poly/kzg/msm.rs:166:5 | 166 | / pub fn new() -> Self { 167 | | Self { 168 | | left: MSMKZG::new(), 169 | | right: MSMKZG::new(), 170 | | } 171 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `-W clippy::new-without-default` implied by `-W clippy::all` help: try adding this | 160 + impl<E: MultiMillerLoop> Default for DualMSM<E> { 161 + fn default() -> Self { 162 + Self::new() 163 + } 164 + } |
this expression creates a reference which is immediately dereferenced by the compiler: halo2_backend/src/poly/kzg/commitment.rs#L69
warning: this expression creates a reference which is immediately dereferenced by the compiler --> halo2_backend/src/poly/kzg/commitment.rs:69:28 | 69 | Self::write_custom(&self, writer, SerdeFormat::RawBytes) | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all`
this lifetime isn't used in the function definition: halo2_backend/src/plonk/keygen.rs#L43
warning: this lifetime isn't used in the function definition --> halo2_backend/src/plonk/keygen.rs:43:18 | 43 | pub fn keygen_vk<'params, C, P>( | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes = note: `-W clippy::extra-unused-lifetimes` implied by `-W clippy::all`
this expression creates a reference which is immediately dereferenced by the compiler: halo2_proofs/examples/serialization.rs#L188
warning: this expression creates a reference which is immediately dereferenced by the compiler --> halo2_proofs/examples/serialization.rs:188:9 | 188 | &verifier_params, | ^^^^^^^^^^^^^^^^ help: change this to: `verifier_params` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all`
this lifetime isn't used in the impl: halo2_backend/src/poly/kzg/strategy.rs#L67
warning: this lifetime isn't used in the impl --> halo2_backend/src/poly/kzg/strategy.rs:67:6 | 67 | impl<'params, E> AccumulatorStrategy<E> | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
this lifetime isn't used in the impl: halo2_backend/src/poly/kzg/strategy.rs#L44
warning: this lifetime isn't used in the impl --> halo2_backend/src/poly/kzg/strategy.rs:44:6 | 44 | impl<'params, E> GuardKZG<E> | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
this lifetime isn't used in the impl: halo2_backend/src/poly/kzg/strategy.rs#L33
warning: this lifetime isn't used in the impl --> halo2_backend/src/poly/kzg/strategy.rs:33:6 | 33 | impl<'params, E> Guard<KZGCommitmentScheme<E>> for GuardKZG<E> | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
you should consider adding a `Default` implementation for `DualMSM<E>`: halo2_backend/src/poly/kzg/msm.rs#L166
warning: you should consider adding a `Default` implementation for `DualMSM<E>` --> halo2_backend/src/poly/kzg/msm.rs:166:5 | 166 | / pub fn new() -> Self { 167 | | Self { 168 | | left: MSMKZG::new(), 169 | | right: MSMKZG::new(), 170 | | } 171 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `-W clippy::new-without-default` implied by `-W clippy::all` help: try adding this | 160 + impl<E: MultiMillerLoop> Default for DualMSM<E> { 161 + fn default() -> Self { 162 + Self::new() 163 + } 164 + } |
this expression creates a reference which is immediately dereferenced by the compiler: halo2_backend/src/poly/kzg/commitment.rs#L69
warning: this expression creates a reference which is immediately dereferenced by the compiler --> halo2_backend/src/poly/kzg/commitment.rs:69:28 | 69 | Self::write_custom(&self, writer, SerdeFormat::RawBytes) | ^^^^^ help: change this to: `self` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `-W clippy::needless-borrow` implied by `-W clippy::all`
this lifetime isn't used in the function definition: halo2_backend/src/plonk/keygen.rs#L43
warning: this lifetime isn't used in the function definition --> halo2_backend/src/plonk/keygen.rs:43:18 | 43 | pub fn keygen_vk<'params, C, P>( | ^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes = note: `-W clippy::extra-unused-lifetimes` implied by `-W clippy::all`
Clippy (beta)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Clippy (beta)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/