Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pci-load-balancer): Load Balancer 3AZ beta #14703

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file not shown.
2 changes: 1 addition & 1 deletion packages/manager/apps/pci-load-balancer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"@ovh-ux/manager-config": "^8.0.1",
"@ovh-ux/manager-core-api": "^0.9.0",
"@ovh-ux/manager-core-utils": "^0.3.0",
"@ovh-ux/manager-pci-common": "^0.14.2",
"@ovh-ux/manager-pci-common": "file:./ovh-ux-manager-pci-common-v0.14.6.tgz",
"@ovh-ux/manager-react-components": "^1.41.2",
"@ovh-ux/manager-react-core-application": "^0.11.4",
"@ovh-ux/manager-react-shell-client": "^0.8.4",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,8 @@
"octavia_load_balancer_create_name_field_label": "Nom du Load Balancer",
"octavia_load_balancer_create_name_field_help": "Doit uniquement contenir des nombres, lettres, underscores, tirets ou points.",
"octavia_load_balancer_create_submit": "Créer un Load Balancer",
"octavia_load_balancer_create_banner": "Votre Load Balancer est en cours de création. Cela ne prendra que quelques minutes."
"octavia_load_balancer_create_banner": "Votre Load Balancer est en cours de création. Cela ne prendra que quelques minutes.",
"octavia_load_balancer_create_private_network": "Il n'existe aucun réseau privé dans la région sélectionnée. Assurez-vous de <link /> avant la création du Load Balancer.",
Copy link
Contributor

@SimonChaumet SimonChaumet Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a word missing in <link /> ?

"octavia_load_balancer_create_private_network_label": "créer un réseau privé",
"octavia_load_balancer_create_region_3az_price": "Load Balancer est actuellement en phase Beta dans la zone Paris (eu-west-par) et est donc gratuite durant cette période."
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,4 @@ export const useGetFlavor = (
],
queryFn: () => getFlavor(projectId, regionName, addon),
enabled: !!projectId && !!regionName && !!addon,
throwOnError: true,
});
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ export const useGetFloatingIps = (projectId: string, region: string) => {
queryKey: ['project', projectId, 'region', region, 'floating-ips'],
queryFn: () => getFloatingIps(projectId, region),
enabled: !!projectId && !!region,
throwOnError: true,
});

const defaultFloatingIp = useDefaultFloatingIp();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ export const useGetPrivateNetworkSubnets = (
],
queryFn: () => getPrivateNetworkSubnets(projectId, region, networkId),
enabled: !!projectId && !!region && !!networkId,
throwOnError: true,
});

const list = useMemo(() => {
Expand All @@ -106,7 +105,6 @@ export const useGetRegionPrivateNetworks = (
queryKey: ['project', projectId, 'region', region, 'networks'],
queryFn: () => getRegionPrivateNetworks(projectId, region),
enabled: !!projectId && !!region,
throwOnError: true,
});

const list = useMemo(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export type TRegion = {
macroName: string;
microName: string;
continent: string;
type: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can import from pci-common or improve this typing with the available types

};

// @TODO this part looks similar to what have been created in the region selector
Expand Down Expand Up @@ -61,6 +62,7 @@ export const useGetRegions = (
region.name,
)}`,
),
type: region.type,
});
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { useTranslation } from 'react-i18next';
import { ODS_TEXT_LEVEL, ODS_TEXT_SIZE } from '@ovhcloud/ods-components';
import { ODS_THEME_COLOR_INTENT } from '@ovhcloud/ods-common-theming';
import { useEffect } from 'react';
import { useMedia } from 'react-use';
import { useCreateStore } from './store';
import {
useGetPrivateNetworkSubnets,
Expand All @@ -32,7 +31,6 @@ import { useGetFloatingIps } from '@/api/hook/useFloatingIps';
export default function CreatePage(): JSX.Element {
const { me } = useMe();
const { data: addons, isPending: isAddonsPending } = useGetAddons();
const isMobile = useMedia(`(max-width: 768px)`);

const projectHref = useProjectUrl('public-cloud');

Expand Down Expand Up @@ -161,7 +159,6 @@ export default function CreatePage(): JSX.Element {
isLoading={isRegionsPending}
regions={regions}
ovhSubsidiary={me?.ovhSubsidiary}
isMobile={isMobile}
/>
<IpStep
floatingIps={filteredFloatingIps}
Expand Down
Loading
Loading