feat(pci-load-balancer): Load Balancer 3AZ beta #14703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: TAPC-2270 Signed-off-by: tsiorifamonjena <[email protected]>
ref: TAPC-2270 Signed-off-by: tsiorifamonjena <[email protected]>
ref: TAPC-2270 Signed-off-by: tsiorifamonjena <[email protected]>
feat(pci-load-balancer): [Load Balancer 3AZ] - Configuration page - Add 3-AZ tag
ref: TAPC-1523 Signed-off-by: tsiorifamonjena <[email protected]>
ref: TAPC-1523 Signed-off-by: tsiorifamonjena <[email protected]>
…-1523 feat(pci-load-balancer): Configuration page - Notify user if location selected has no private network
Tsiorifamonjena
requested review from
sidlynx,
seven-amid,
qpavy,
anooparveti and
darsene
ref: TAPC-2486 Signed-off-by: tsiorifamonjena <[email protected]>
feat(pci.load-balancer): [Load Balancer 3AZ] - Configuration page - Add a banner for Paris-3-AZ Beta
ref: TAPC- 2270 Signed-off-by: tsiorifamonjena <[email protected]>
qpavy
previously approved these changes
Dec 24, 2024
lionel95200x
previously approved these changes
Dec 24, 2024
oalkabouss
previously approved these changes
Dec 26, 2024
ref:TAPC-2304 Signed-off-by: tsiorifamonjena <[email protected]>
Tsiorifamonjena
dismissed stale reviews from oalkabouss, lionel95200x, and qpavy
via
656688b
ref: TAPC-2304 Signed-off-by: tsiorifamonjena <[email protected]>
ref: TAPC-2304 Signed-off-by: tsiorifamonjena <[email protected]>
ref: TAPC-2304 Signed-off-by: tsiorifamonjena <[email protected]>
| @@ -41,5 +41,8 @@ | |||
| "octavia_load_balancer_create_name_field_label": "Nom du Load Balancer", | |||
| "octavia_load_balancer_create_name_field_help": "Doit uniquement contenir des nombres, lettres, underscores, tirets ou points.", | |||
| "octavia_load_balancer_create_submit": "Créer un Load Balancer", | |||
| "octavia_load_balancer_create_banner": "Votre Load Balancer est en cours de création. Cela ne prendra que quelques minutes." | |||
| "octavia_load_balancer_create_banner": "Votre Load Balancer est en cours de création. Cela ne prendra que quelques minutes.", | |||
| "octavia_load_balancer_create_private_network": "Il n'existe aucun réseau privé dans la région sélectionnée. Assurez-vous de <link /> avant la création du Load Balancer.", | |||
There was a problem hiding this comment.
is there a word missing in <link /> ?
| @@ -12,6 +12,7 @@ export type TRegion = { | |||
| macroName: string; | |||
| microName: string; | |||
| continent: string; | |||
| type: string; | |||
There was a problem hiding this comment.
I think you can import from pci-common or improve this typing with the available types
Comment on lines
+11
to
+18
| vi.mock('@ovh-ux/manager-pci-common', () => ({ | ||
| useProject: vi.fn().mockReturnValue({ data: { project_id: 'project_id' } }), | ||
| RegionSelector: () => <div />, | ||
| usePCICommonContextFactory: vi.fn(), | ||
| PCICommonContext: { | ||
| Provider: () => <></>, | ||
| }, | ||
| })); |
There was a problem hiding this comment.
I think you should just mock the whole module and then import each element that you need to mock specifically
Comment on lines
+54
to
+56
| const allRegions = regions | ||
| ? Array.from(regions, ([, values]) => values) | ||
| : []; |
There was a problem hiding this comment.
I am not sure to understand this, could this be a .values() instead ?
Also this could be simplified I think
| <RegionSelector | ||
| projectId={project.project_id} | ||
| onSelectRegion={(selectedRegion) => { | ||
| store.set.region(undefined); |
There was a problem hiding this comment.
Why set to undefined everytime ?
ref: TAPC-2304 Signed-off-by: tsiorifamonjena <[email protected]>
github-actions
bot
added
the
dependencies
|
| Name | Status | Previous | Current |
|---|---|---|---|
@ovh-ux/manager-pci-common |
0.14.2 | 0.15.0 |
Signed-off-by: CDS Translator Agent <[email protected]>
|
qpavy
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
developDescription
Related